79874[!!!][TASK] Introduce capabilities bit set
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php4+7 −16
- typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php+8 −11
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+13 −15
- typo3/sysext/core/Classes/Resource/Capabilities.php6new+72 −0
- typo3/sysext/core/Classes/Resource/ResourceStorage.php4+20 −27
- typo3/sysext/core/Classes/Resource/ResourceStorageInterface.php+0 −17
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101291-IntroduceCapabilitiesBitSet.rstnew+74 −0
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+3 −3
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+0 −1
- typo3/sysext/core/Tests/Functional/Resource/StorageRepositoryTest.php+2 −1
Review log 1418
-
Alexander Schnitzler uploaded patch set 1 07/07/23, 11:39
-
core-ci voted on patch set 1 V -1 07/07/23, 11:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43895
-
Alexander Schnitzler uploaded patch set 2
V -107/07/23, 13:31 -
core-ci voted on patch set 2 V +1 07/07/23, 13:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43913
-
Alexander Schnitzler uploaded patch set 3
V +107/07/23, 14:04 -
Alexander Schnitzler wrote 07/07/23, 14:05
Topic set to FAL -
core-ci voted on patch set 3 V +1 07/07/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43919
-
Alexander Schnitzler marked it ready for review 07/07/23, 14:17
-
Oliver Klee commented on patch set 3 07/07/23, 14:22
Capabilities.php:43We probably can use `@param` here instead of `@phpstan-param` as IDEs like PhpStorm then would fall back on the native type declaration. Ditto for `hasCapability`.Capabilities.php:45We can add `@return $this` here to let readers and PHPStan know that the same instance is returned, and not only an instance of this class. Ditto for `addCapabilities`.Capabilities.php:51@param self::CAPABILITY_* $capabilitiesAbstractDriver.php:32Do we need to adapt this description?AbstractDriver.php:106We probably can use `@param` here instead, too. Also, we can use the short class name, I think. -
Benni Mack commented on patch set 3 07/07/23, 14:26
ResourceStorage.php:244great patch. One remark. Can we move this to a fromStorageRecord() factory method? -
Alexander Schnitzler uploaded patch set 4
V +107/07/23, 14:55 -
Alexander Schnitzler commented on patch set 4 07/07/23, 14:55
Capabilities.php:43ReplyAckCapabilities.php:45ReplyAckCapabilities.php:51ReplyAckAbstractDriver.php:32ReplyAckAbstractDriver.php:106ReplyAckResourceStorage.php:244ReplyWell, that's not possible, because we are in the constructor of the ResourceStorage and we don't have a final object here yet. We could implement a factory method based on the incoming `$storageRecord` variable but that's an array and a bit wishy-washy, don't you think? -
Oliver Klee voted on patch set 4 CR +1 07/07/23, 14:59
-
core-ci voted on patch set 4 V +1 07/07/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43921
-
Benni Mack commented on patch set 4 07/07/23, 15:28
ResourceStorage.php:244Replyoh no. I thought of having a factory method in the capabilities class -
Oliver Klee voted on patch set 4 V +1 07/07/23, 16:10
-
Benni Mack commented on patch set 4 V +2 CR +2 07/08/23, 11:25
ResourceStorage.php:244ReplyDone -
Benni Mack merged patch set 5 07/08/23, 11:25