Review main Merged

79875[TASK] Update URL bar in nested backend installtool

Benjamin Franzke CR +2 V +2 Easy +16 −4 updated 07/10/23, 20:31

Commit message

Map backend URLs like
/typo3/install.php?install%5Bcontroller%5D=settings
to /typo3/module/tools/settings for display in the
browsers URL bar.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 89

  1. Benjamin Franzke uploaded patch set 1 07/07/23, 13:10

  2. core-ci voted on patch set 1 V +1 07/07/23, 13:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43911

  3. Benjamin Franzke commented on patch set 1 V -1 07/07/23, 13:54

    doesn't work for benni, will check
  4. Benni Mack voted on patch set 1 V +1 CR +1 07/07/23, 14:28

  5. Benjamin Franzke voted on patch set 1 V 0 07/07/23, 16:24

  6. Andreas Kienast voted on patch set 1 CR +1 07/10/23, 06:14

  7. Stefan Bürk voted on patch set 1 V +1 CR +1 07/10/23, 20:28

  8. Stefan Bürk voted on patch set 1 V +2 CR +2 07/10/23, 20:31

  9. Stefan Bürk merged patch set 2 07/10/23, 20:31