79877[TASK] Let ClassSchema skip static properties/methods
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 5
- Build/phpstan/phpstan-baseline.neon+0 −5
- typo3/sysext/extbase/Classes/Reflection/ClassSchema.php+8 −0
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfMethods.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/Fixture/DummyClassWithAllTypesOfProperties.php+0 −8
- typo3/sysext/extbase/Tests/Unit/Reflection/ClassSchemaTest.php+1 −15
Review log 910
-
Alexander Schnitzler uploaded patch set 1 07/07/23, 13:59
-
Alexander Schnitzler wrote 07/07/23, 13:59
Topic set to extbase -
core-ci voted on patch set 1 V +1 07/07/23, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43918
-
Alexander Schnitzler marked it ready for review 07/07/23, 14:07
-
Alexander Schnitzler commented on patch set 1 CR -1 07/07/23, 14:08
Will modify once more. -
Alexander Schnitzler commented on patch set 1 07/07/23, 14:15
Reply
No, I won't. ^^ -
Alexander Schnitzler voted on patch set 1 CR 0 07/07/23, 14:16
-
Oliver Klee voted on patch set 1 V +1 CR +1 07/07/23, 14:18
-
Benni Mack voted on patch set 1 V +2 CR +2 07/08/23, 12:00
-
Benni Mack merged patch set 2 07/08/23, 12:00