79878[!!!][TASK] Introduce type declarations in PropertyMappingConfigurationInterface
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Andreas Kienast +1
-
Verified V +2 Done
- Benni Mack +2
- Oliver Klee +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 7
- Build/phpstan/phpstan-baseline.neon+0 −90
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-101292-Strong-typedPropertyMappingConfigurationInterface.rstnew+36 −0
- typo3/sysext/extbase/Classes/Mvc/Controller/MvcPropertyMappingConfigurationService.php+3 −3
- typo3/sysext/extbase/Classes/Property/PropertyMapper.php+4 −6
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfiguration.php+72 −82
- typo3/sysext/extbase/Classes/Property/PropertyMappingConfigurationInterface.php+48 −17
- typo3/sysext/extbase/Tests/Unit/Property/PropertyMappingConfigurationTest.php+7 −6
Review log 1421
-
Alexander Schnitzler uploaded patch set 1 07/07/23, 16:27
-
Alexander Schnitzler wrote 07/07/23, 16:27
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 07/07/23, 16:33
-
core-ci voted on patch set 1 V +1 07/07/23, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43922
-
core-ci voted on patch set 2 V +1 07/07/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43924
-
Benni Mack uploaded patch set 3
V +103/25/25, 10:45 -
Benni Mack uploaded patch set 4 03/25/25, 10:51
-
Benni Mack marked it ready for review 03/25/25, 10:51
-
Benni Mack updated the commit message in patch set 5 03/25/25, 10:52
-
core-ci voted on patch set 3 V +1 03/25/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76237
-
core-ci voted on patch set 4 V +1 03/25/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76238
-
core-ci voted on patch set 5 V +1 03/25/25, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76239
-
Andreas Kienast uploaded patch set 6
V +103/25/25, 11:14 -
core-ci voted on patch set 6 V -1 03/25/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76240
-
Andreas Kienast commented on patch set 6 03/25/25, 11:26
Reverting patch set 6, breaks tests... -
Andreas Kienast uploaded patch set 7
V -103/25/25, 11:26 -
core-ci voted on patch set 7 V +1 03/25/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76241
-
Andreas Kienast voted on patch set 7 CR +1 V +1 03/25/25, 11:36
-
Oliver Klee voted on patch set 7 CR +1 V +1 03/25/25, 11:38
-
Benni Mack voted on patch set 7 CR +2 V +2 03/25/25, 13:02
-
Benni Mack merged patch set 8 03/25/25, 13:02