Review main Merged Breaking

79878[!!!][TASK] Introduce type declarations in PropertyMappingConfigurationInterface

Alexander Schnitzler CR +2 V +2 Hard +170 −204 updated 03/25/25, 13:02

Commit message

Also introduces type declarations in PropertyMappingConfiguration
to match the interface.

And to improve the API and not to rely on the implementation,
PropertyMappingConfigurationInterface has gotten new method
stubs.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 1421

  1. Alexander Schnitzler uploaded patch set 1 07/07/23, 16:27

  2. Alexander Schnitzler wrote 07/07/23, 16:27

    Topic set to extbase
  3. Alexander Schnitzler uploaded patch set 2 07/07/23, 16:33

  4. core-ci voted on patch set 1 V +1 07/07/23, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43922

  5. core-ci voted on patch set 2 V +1 07/07/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43924

  6. Benni Mack uploaded patch set 3 V +1 03/25/25, 10:45

  7. Benni Mack uploaded patch set 4 03/25/25, 10:51

  8. Benni Mack marked it ready for review 03/25/25, 10:51

  9. Benni Mack updated the commit message in patch set 5 03/25/25, 10:52

  10. core-ci voted on patch set 3 V +1 03/25/25, 10:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76237

  11. core-ci voted on patch set 4 V +1 03/25/25, 11:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76238

  12. core-ci voted on patch set 5 V +1 03/25/25, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76239

  13. Andreas Kienast uploaded patch set 6 V +1 03/25/25, 11:14

  14. core-ci voted on patch set 6 V -1 03/25/25, 11:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76240

  15. Andreas Kienast commented on patch set 6 03/25/25, 11:26

    Reverting patch set 6, breaks tests...
  16. Andreas Kienast uploaded patch set 7 V -1 03/25/25, 11:26

  17. core-ci voted on patch set 7 V +1 03/25/25, 11:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76241

  18. Andreas Kienast voted on patch set 7 CR +1 V +1 03/25/25, 11:36

  19. Oliver Klee voted on patch set 7 CR +1 V +1 03/25/25, 11:38

  20. Benni Mack voted on patch set 7 CR +2 V +2 03/25/25, 13:02

  21. Benni Mack merged patch set 8 03/25/25, 13:02