79880[BUGFIX] Fix sorting in FileBrowser
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1418
-
Andreas Nedbal uploaded patch set 1 07/08/23, 14:19
-
core-ci voted on patch set 1 V -1 07/08/23, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43944
-
Andreas Nedbal uploaded patch set 2
V -107/08/23, 14:37 -
core-ci voted on patch set 2 V +1 07/08/23, 14:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43945
-
Oliver Klee commented on patch set 2 07/10/23, 18:35
-
Andreas Nedbal uploaded patch set 3
V +107/10/23, 18:38 -
Andreas Nedbal commented on patch set 3 07/10/23, 18:39
FileBrowser.php:126ReplyDone -
core-ci voted on patch set 3 V +1 07/10/23, 18:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43982
-
Kevin Appelt voted on patch set 3 CR +1 07/10/23, 19:08
-
Benjamin Franzke uploaded patch set 4
CR +1V +107/10/23, 19:53 -
Benjamin Franzke commented on patch set 4 07/10/23, 19:53
FileBrowser.php:126ReplyNo need for an integer typecast at all, strict string comparison will suffice, as QueryParams are always strings. -
core-ci voted on patch set 4 V +1 07/10/23, 20:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43986
-
Oli Bartsch voted on patch set 4 V +1 CR +1 07/10/23, 20:16
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 07/10/23, 20:17
-
Benjamin Franzke merged patch set 5 07/10/23, 20:17
-
Nikita Hovratov commented on patch set 5 07/10/23, 20:28
FileBrowser.php:125Post merge remark: The fallback to "asc" is completely wrong. This parameter stands for the "sorting field" (bad naming). It should be just an empty string. Asc or desc is determined by the next parameter "reverse" (true = desc, false = asc). -
Stefan Bürk commented on patch set 5 07/10/23, 20:44
FileBrowser.php:125Replyshould be fixed then -
Stefan Bürk commented on patch set 5 07/10/23, 20:48
FileBrowser.php:125Reply
FileBrowser.php:126