79884[!!!][TASK] Introduce type declarations in DriverInterface
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
-
Verified V +2 Done
- Stefan Bürk +2
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/core/Classes/Resource/Driver/AbstractDriver.php+9 −24
- typo3/sysext/core/Classes/Resource/Driver/AbstractHierarchicalFilesystemDriver.php+5 −3
- typo3/sysext/core/Classes/Resource/Driver/DriverInterface.php27+153 −153
- typo3/sysext/core/Classes/Resource/Driver/LocalDriver.php+118 −125
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+9 −2
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101309-IntroduceTypeDeclarationsInDriverInterface.rstnew+66 −0
- typo3/sysext/core/Tests/Functional/Resource/Driver/LocalDriverTest.php+1 −1
- typo3/sysext/core/Tests/Functional/Resource/ResourceStorageTest.php+12 −12
Review log 2028
Show 23 earlier messages
-
Alexander Schnitzler uploaded patch set 1 07/09/23, 08:54
-
core-ci voted on patch set 1 V -1 07/09/23, 09:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43955
-
Alexander Schnitzler uploaded patch set 2
V -107/09/23, 16:48
-
core-ci voted on patch set 2 V +1 07/09/23, 16:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43958
-
Alexander Schnitzler uploaded patch set 3
V +107/11/23, 07:54 -
Alexander Schnitzler wrote 07/11/23, 07:57
Topic set to FAL -
core-ci voted on patch set 3 V +1 07/11/23, 08:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44012
-
Alexander Schnitzler marked it ready for review 07/11/23, 08:05
-
Oliver Klee commented on patch set 3 V +1 07/11/23, 09:54
DriverInterface.php:121`?string` (also in the implementing classes)DriverInterface.php:137While we're at it: `@return array<string, string>` (also in the implementing classes)DriverInterface.php:181Is this a `non-empty-string`?DriverInterface.php:202Is this a `non-empty-string`?DriverInterface.php:285Nitpick: `int<0, max>` (with the space added)DriverInterface.php:323Nitpick: `{r: bool, w: bool}`DriverInterface.php:334`: void`DriverInterface.php:365Do we know more about the array?DriverInterface.php:367`: array`DriverInterface.php:383Nitpick (2x): Please let's have a space after the comma for improved readability. Ditto for the other occurrences in this file.DriverInterface.php:401`: array`DriverInterface.php:436`: array` -
Alexander Schnitzler rebased onto patch set 4
V +107/18/23, 13:57 -
core-ci voted on patch set 4 V +1 07/18/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44259
-
Alexander Schnitzler uploaded patch set 5
V +107/18/23, 14:15 -
Alexander Schnitzler commented on patch set 5 07/18/23, 14:17
DriverInterface.php:121ReplyDoneDriverInterface.php:137ReplyDoneDriverInterface.php:181ReplyDoneDriverInterface.php:202ReplyDoneDriverInterface.php:285ReplyDoneDriverInterface.php:323ReplyDoneDriverInterface.php:334ReplyDoneDriverInterface.php:365ReplyDoneDriverInterface.php:367ReplyDoneDriverInterface.php:383ReplyDoneDriverInterface.php:401ReplyDoneDriverInterface.php:436ReplyDone -
core-ci voted on patch set 5 V +1 07/18/23, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44261
-
Oliver Klee voted on patch set 5 V +1 CR +1 07/18/23, 14:37
-
Christian Kuhn rebased onto patch set 6
CR +1V +107/19/23, 08:53 -
core-ci voted on patch set 6 V +1 07/19/23, 09:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44297
-
Christian Kuhn uploaded patch set 7
V +107/19/23, 09:22 -
Christian Kuhn voted on patch set 7 V +1 CR +1 07/19/23, 09:22
-
core-ci voted on patch set 7 V +1 07/19/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44300
-
Stefan Bürk commented on patch set 7 07/19/23, 09:50
DriverInterface.php:365This should be `@return array{` without the space: See: https://phpstan.org/r/72c63067-e727-4a81-9cf3-720829c69613 (ok) vs.: https://phpstan.org/r/11e9b704-e1c7-45c1-b456-3fdef8ee5c35 (error) Could not find andy information since which version PHPStan supports multiline array shapes. Have we the min version already required for this ? Maybe the space check comes with a higher level. @Oliver Klee, does you have some more information on this ? -
Alexander Schnitzler commented on patch set 7 07/19/23, 10:07
DriverInterface.php:365Replyhttps://phpstan.org/writing-php-code/phpdoc-types#array-shapes doesn't state a version number, therefore I take it this feature had been added before the stable 1.0.0. phpstan doesn't find the issue because we are on level 5 and this error is raised as of level 6. -
Alexander Schnitzler uploaded patch set 8
CR +1V +107/19/23, 10:13 -
core-ci voted on patch set 8 V +1 07/19/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44302
-
Christian Kuhn voted on patch set 8 V +1 CR +1 07/19/23, 10:23
-
Stefan Bürk voted on patch set 8 V +2 CR +2 07/19/23, 10:28
-
Stefan Bürk commented on patch set 8 07/19/23, 10:28
DriverInterface.php:365ReplyDone -
Stefan Bürk merged patch set 9 07/19/23, 10:28