Review main Abandoned

79916[TASK] Fixed typoscript example for enabling the index for EXT:indexed_sea

TYPO3com CR 0 V 0 Easy +1 −1 updated 07/19/23, 07:03

Commit message

Shouldn't this be `config.index_enable` instead of
`page.config.index_enable` ? According to the settings inside
**EXT:indexed_search/Configuration/TypoScript/setup.typoscript** there is
no page object around it and the settings for the language below don't
habe a page-object around it too.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 35

  1. TYPO3com uploaded patch set 1 07/10/23, 10:37

  2. core-ci voted on patch set 1 V +1 07/10/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43978

  3. Oli Bartsch commented on patch set 1 CR -1 07/11/23, 08:15

    Unresolved

    This is correct. The reason for using "page" here is explained in the paragraph above. It's an example configuration, based on the fact that a PAGE object with the key "page" exists.
  4. Christian Kuhn commented on patch set 1 CR -1 07/19/23, 07:03

    ack to oliver. will abandon.
  5. Christian Kuhn abandoned the change 07/19/23, 07:03