Review 12.4 Merged

79921[BUGFIX] Fix sudo mode in non-Sec-Fetch-Dest context

Benjamin Franzke CR +2 V +2 Easy +4 −6 updated 07/10/23, 20:44

Commit message

Since #94084 all module URLs are automatically framed by
the TYPO3 main controller whenever they are opened in a
Sec-Fetch-Dest aware request. (HTTPS or localhost domain)
The intention of API is to allow module-links
to be opened in a new tab by user intent – but due to
technical limitation that feature is limited to
secure contexts, and must therefore not be relied on
as an API for internal redirects.

sudo mode made use of this API and redirected
via top.location to the privileged module, relying
on the fact that iframe module-requests where detected
to be loaded in the wrong context, to produce
a redirect to the proper backend-frame, this didn't
work for non HTTPS requests.

This workaround has been done to remove "sudo-mode"
from the URL bar. That workaround is no longer needed
as #101287 added support for installtool URL
bar synchronisation.
ContentContainer API is now used to set the URL.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 34

  1. Benjamin Franzke uploaded patch set 1 07/10/23, 20:26

  2. core-ci voted on patch set 1 V +1 07/10/23, 20:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43990

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/10/23, 20:44

  4. Benjamin Franzke merged patch set 2 07/10/23, 20:44