Review 12.4 Merged

79922[BUGFIX] Support deferred ConsumerScope in GlobalEventHandler

Benjamin Franzke CR +2 V +2 Easy +20 −17 updated 07/10/23, 20:59

Commit message

The GlobalEventHandler changes the location of the current (target)
window. The location is set to a given destination without any ability
to interrupt. The existing ConsumerScope API isn't used even if the
current window is the ContentContainer. This patch extends the handling
of a navigation action by checking its target window and using proper
ContentContainer API to set the location. Therefore registered listener
can deny a location change and trigger own functions.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Benjamin Franzke uploaded patch set 1 07/10/23, 20:26

  2. core-ci voted on patch set 1 V +1 07/10/23, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43991

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/10/23, 20:59

  4. Benjamin Franzke merged patch set 2 07/10/23, 20:59