Review 11.5 Merged

79924[BUGFIX] Fix workspace stage-change mail recipient selection

Benjamin Franzke CR +2 V +2 Easy +4 −3 updated 07/11/23, 08:06

Commit message

Stage-change notification mails have only been delivered to the last
recipient off the list of possible recipients, because
Utility.convertFormToObject failed to detect checkbox elements
from (other) frames.
In this case the to-be-converted form elements are created on the top
frame (modal contents are placed outside list frame on the top frame).

Due to JavaScript being prototype based, instanceof checks do
only operate per-frame. Prototypes are bound to the current window.
`foo instanceof HTMLInputElement` is basically a shortcut
and equivalent to `foo instanceof window.HTMLInputElement`
while `window != top.window`.

Instead of `instanceof` checks, we switch to a `tagName` comparision
which is usable for cross-frame HTMLElement type detection.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benjamin Franzke uploaded patch set 1 07/10/23, 21:15

  2. core-ci voted on patch set 1 V +1 07/10/23, 21:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43995

  3. Benjamin Franzke marked it ready for review 07/11/23, 05:38

  4. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/11/23, 08:06

  5. Benjamin Franzke merged patch set 2 07/11/23, 08:06