Review main Merged Breaking

79955[!!!][TASK] Introduce type declarations for GU networking-related methods

Oliver Klee CR +2 V +2 Normal +107 −56 updated 07/18/23, 11:38

Commit message

Native return and param type declarations have been introduced for the
following methods of `\TYPO3\CMS\Core\Utility\GeneralUtility`:

- `cmpFQDN`
- `cmpIP`
- `cmpIPv4`
- `cmpIPv6`
- `getUrl`
- `isOnCurrentHost`
- `isValidUrl`
- `locationHeaderUrl`
- `normalizeIPv6`
- `sanitizeLocalUrl`
- `validEmail`
- `validIP`
- `validIPv4`
- `validIPv6`
- `validPathStr`

Also, type declarations have been added to the corresponding unit tests.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3