Review 12.4 Merged

79991[BUGFIX] Use 12/24 hour format in date picker depending on client

Benjamin Franzke CR +2 V +2 Easy +2 −1 updated 07/17/23, 07:06

Commit message

flatpicker uses the 12 hours format by default, offering an AM/PM
selector next to the time dropdowns. In some regions, using this setting
is rather unusual and may lead to user errors.

To relax the sitation, browser API is used to determine the time format
based on the client's language. Unfortunately, it seems browsers always
assume the format based on the language only and ignore potentially
overridden settings in the operating system.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benjamin Franzke commented on patch set 1 07/17/23, 06:53

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/17/23, 07:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44198

  3. Benjamin Franzke voted on patch set 1 V +2 CR +2 07/17/23, 07:06

  4. Benjamin Franzke merged patch set 2 07/17/23, 07:06