Review main Merged

80007[BUGFIX] Mark current page in indexed_search via `aria-current`

Andreas Kienast CR +2 V +2 Easy +16 −10 updated 07/12/23, 16:19

Commit message

To support screen readers, the current page in the indexed_search
pagination is now enriched with the `aria-current` attribute.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/12/23, 07:24

  2. core-ci voted on patch set 1 V +1 07/12/23, 07:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44068

  3. Benjamin Franzke commented on patch set 1 CR -1 07/12/23, 08:34

    Please see: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-current > In a breadcrumb list, when a link within a set of pagination links is styled to indicate the user is currently on that page, aria-current="page" should be set on that link. aria-current="page" should be placed on the link, not on <li>
  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 07/12/23, 08:54

  5. Benjamin Franzke commented on patch set 2 CR +1 07/12/23, 08:55

    Thanks
  6. core-ci voted on patch set 2 V +1 07/12/23, 09:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44076

  7. Benjamin Franzke voted on patch set 2 V +1 07/12/23, 09:10

  8. Stefan Bürk voted on patch set 2 CR +1 07/12/23, 15:50

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 07/12/23, 16:06

  10. Stefan Bürk merged patch set 3 07/12/23, 16:19