Review main Merged

80014[BUGFIX] Do not store bollocks markup in icon cache

Andreas Kienast CR +2 V +2 Easy +2 −2 updated 07/13/23, 05:55

Commit message

In very rare cases it may happen that a backend session is not valid
anymore when an icon is loaded within the TYPO3 backend. If the icon
is not in the user's localStorage, the TYPO3 backend login is stored
in localStorage instead.

To catch this issue in the future, additional checks were implemented:

* the response shall not come from a redirected request, which could be
  an indicator for unwanted markup
* the received markup must start with "<span"

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Georg Ringer +1
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Andreas Kienast uploaded patch set 1 07/12/23, 14:57

  2. Andreas Kienast uploaded patch set 2 07/12/23, 14:59

  3. Oliver Klee voted on patch set 2 CR +1 07/12/23, 15:02

  4. core-ci voted on patch set 1 V +1 07/12/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44085

  5. core-ci voted on patch set 2 V +1 07/12/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44086

  6. Benjamin Franzke commented on patch set 2 V +1 CR +1 07/12/23, 15:25

    Nice! (puzzled me for quite some time, but I didn't realize it was caused by the logout redirect ¯\_(ツ)_/¯) Although I think it could/should be a public-route, to be usable during login/mfa by providers that use <typo3-backend-icon> at some point. But that's something for another patch.
  7. Stefan Bürk commented on patch set 2 V +1 CR +1 07/12/23, 16:12

    Due to this is TypeScript / JavaScript I leave the merging to someone more experienced for the backports.
  8. Georg Ringer voted on patch set 2 CR +1 07/12/23, 17:09

  9. Andreas Kienast voted on patch set 2 V +2 CR +2 07/13/23, 05:55

  10. Andreas Kienast merged patch set 3 07/13/23, 05:55