80014[BUGFIX] Do not store bollocks markup in icon cache
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Georg Ringer +1
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 2
Review log 810
-
Andreas Kienast uploaded patch set 1 07/12/23, 14:57
-
Andreas Kienast uploaded patch set 2 07/12/23, 14:59
-
Oliver Klee voted on patch set 2 CR +1 07/12/23, 15:02
-
core-ci voted on patch set 1 V +1 07/12/23, 15:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44085
-
core-ci voted on patch set 2 V +1 07/12/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44086
-
Benjamin Franzke commented on patch set 2 V +1 CR +1 07/12/23, 15:25
Nice! (puzzled me for quite some time, but I didn't realize it was caused by the logout redirect ¯\_(ツ)_/¯) Although I think it could/should be a public-route, to be usable during login/mfa by providers that use <typo3-backend-icon> at some point. But that's something for another patch. -
Stefan Bürk commented on patch set 2 V +1 CR +1 07/12/23, 16:12
Due to this is TypeScript / JavaScript I leave the merging to someone more experienced for the backports. -
Georg Ringer voted on patch set 2 CR +1 07/12/23, 17:09
-
Andreas Kienast voted on patch set 2 V +2 CR +2 07/13/23, 05:55
-
Andreas Kienast merged patch set 3 07/13/23, 05:55