Review main Merged

80023[BUGFIX] Make icon cache in localStorage version-aware

Andreas Kienast CR +2 V +2 Easy +6 −17 updated 07/18/23, 06:13

Commit message

The identifier for the icon cache used in the client's localStorage is
now version-aware to get a chance of updated icons after a release. It
now uses the same identifier as the backend cache.

Previously, only the registry state itself was taken into account which
may not change if icons assets get updated.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1316

  1. Andreas Kienast uploaded patch set 1 07/14/23, 09:16

  2. Andreas Kienast uploaded patch set 2 07/14/23, 09:23

  3. core-ci voted on patch set 1 V -1 07/14/23, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44130

  4. Oliver Klee commented on patch set 2 07/14/23, 09:29

    IconRegistry.php:217

    Should we make this `@internal` as well (for consistency)?
  5. core-ci voted on patch set 2 V +1 07/14/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44131

  6. Andreas Kienast commented on patch set 2 07/14/23, 09:31

    IconRegistry.php:217 Reply

    It's private already, there's no need to make it internal in any way.
  7. Stefan Bürk commented on patch set 2 V +1 CR +1 07/14/23, 17:16

    IconRegistry.php:217 Reply

    I would say, we should make the class final. Extending "singleton" is use-less like extending static utility classes. Or what do you think ? Note: Meant to be done in a dedicated change.
  8. Oliver Klee commented on patch set 2 07/14/23, 17:54

    I'm all for making it final!
  9. Oliver Klee voted on patch set 2 CR +1 07/14/23, 18:07

  10. Benjamin Franzke uploaded patch set 3 CR +1 V +1 07/17/23, 07:01

  11. Benjamin Franzke commented on patch set 3 07/17/23, 07:01

    hm… I'M not

    IconController.php:54

    As this is a cache identifier that is also used on the filesystem I added another sha1() here, as a simple security precaution to ensure no one can guess a caches files name.
  12. core-ci voted on patch set 3 V +1 07/17/23, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44199

  13. Oliver Klee voted on patch set 3 CR +1 07/17/23, 13:16

  14. Stefan Bürk voted on patch set 3 V +1 CR +1 07/17/23, 15:59

  15. Benjamin Franzke commented on patch set 3 V +2 CR +2 07/18/23, 06:13

    Reply

    …ready with this comment. Forget about it ;)
  16. Benjamin Franzke merged patch set 4 07/18/23, 06:13