80023[BUGFIX] Make icon cache in localStorage version-aware
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1316
-
Andreas Kienast uploaded patch set 1 07/14/23, 09:16
-
Andreas Kienast uploaded patch set 2 07/14/23, 09:23
-
core-ci voted on patch set 1 V -1 07/14/23, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44130
-
Oliver Klee commented on patch set 2 07/14/23, 09:29
-
core-ci voted on patch set 2 V +1 07/14/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44131
-
Andreas Kienast commented on patch set 2 07/14/23, 09:31
IconRegistry.php:217ReplyIt's private already, there's no need to make it internal in any way. -
Stefan Bürk commented on patch set 2 V +1 CR +1 07/14/23, 17:16
IconRegistry.php:217ReplyI would say, we should make the class final. Extending "singleton" is use-less like extending static utility classes. Or what do you think ? Note: Meant to be done in a dedicated change. -
Oliver Klee commented on patch set 2 07/14/23, 17:54
I'm all for making it final! -
Oliver Klee voted on patch set 2 CR +1 07/14/23, 18:07
-
Benjamin Franzke uploaded patch set 3
CR +1V +107/17/23, 07:01 -
Benjamin Franzke commented on patch set 3 07/17/23, 07:01
hm… I'M notIconController.php:54As this is a cache identifier that is also used on the filesystem I added another sha1() here, as a simple security precaution to ensure no one can guess a caches files name. -
core-ci voted on patch set 3 V +1 07/17/23, 07:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44199
-
Oliver Klee voted on patch set 3 CR +1 07/17/23, 13:16
-
Stefan Bürk voted on patch set 3 V +1 CR +1 07/17/23, 15:59
-
Benjamin Franzke commented on patch set 3 V +2 CR +2 07/18/23, 06:13
Reply
…ready with this comment. Forget about it ;) -
Benjamin Franzke merged patch set 4 07/18/23, 06:13
IconRegistry.php:217