Review main Merged

80026[TASK] Remove TYPO3-related items from localStorage when resetting config

Andreas Kienast CR +2 V +2 Easy +4 −1 updated 07/17/23, 08:37

Commit message

If a user decides to reset their configuration for whatever reason, all
TYPO3-related items that are stored in localStorage are now removed as
well.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 07/14/23, 13:15

  2. core-ci voted on patch set 1 V +1 07/14/23, 13:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44138

  3. Oliver Klee voted on patch set 1 CR +1 07/14/23, 13:51

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 07/14/23, 17:11

  5. Benjamin Franzke commented on patch set 1 CR -1 07/17/23, 07:06

    setup-module.ts:54

    Maybe rather `Client.unsetByPrefix('t3-');` `Client.unsetByPrefix('typo3-');` in order to not destroy/mess with possible frontend state?"
  6. Andreas Kienast commented on patch set 1 07/17/23, 07:33

    setup-module.ts:54 Reply

    `Client.unsetByPrefix()` internally uses `t3-` already as a hard-coded prefix. OTOH, there is `Client.clear()` that indeed flushes the full local storage.
  7. Benjamin Franzke commented on patch set 1 V +2 CR +2 07/17/23, 08:36

    setup-module.ts:54 Reply

    Alight, got confused by installtool setting values via `localStorage.setItem('typo3-install-modulesCollapsed', 'false');`
  8. Benjamin Franzke merged patch set 2 07/17/23, 08:37