80029[BUGFIX] Respect item group of custom page type in "New Pages" view
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 6
- typo3/sysext/backend/Classes/Controller/Page/NewMultiplePagesController.php4+31 −13
- typo3/sysext/backend/Classes/Form/FormDataProvider/TcaSelectItems.php+3 −133
- typo3/sysext/backend/Classes/Form/Processor/SelectItemProcessor.phpnew+178 −0
- typo3/sysext/backend/Configuration/Services.yaml+3 −0
- typo3/sysext/backend/Resources/Private/Templates/Page/NewPages.html+2 −2
- typo3/sysext/backend/Tests/Unit/Form/Processor/SelectItemProcessorTest.phpnew+756 −0
Review log 2331
Show 46 earlier messages
-
Nikita Hovratov uploaded patch set 1 07/14/23, 17:23
-
core-ci voted on patch set 1 V -1 07/14/23, 17:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44146
-
Nikita Hovratov uploaded patch set 2
V -107/14/23, 17:39 -
core-ci voted on patch set 2 V +1 07/14/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44147
-
Nikita Hovratov voted on patch set 2 V -1 07/14/23, 17:49
-
Nikita Hovratov uploaded patch set 3
V +107/14/23, 19:12
-
core-ci voted on patch set 3 V +1 07/14/23, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44148
-
Oliver Klee commented on patch set 3 07/14/23, 20:15
Could we cover the new/extracted class with tests? -
Nikita Hovratov uploaded patch set 4
V +107/15/23, 11:04 -
Nikita Hovratov commented on patch set 4 07/15/23, 11:05
Reply
Done. -
core-ci voted on patch set 4 V +1 07/15/23, 11:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44169
-
Oliver Klee voted on patch set 4 V +1 07/15/23, 11:23
-
Stefan Bürk commented on patch set 4 CR -1 07/20/23, 08:34
on it ...GroupAndSortItemsService.php:23Would suggest to make this final and internal. -
Benni Mack commented on patch set 4 07/20/23, 09:20
I like the idea in general!NewMultiplePagesController.php:214I wonder if we can actually move more code like the filtering logic (also from FormEngine) in the new class?GroupAndSortItemsService.php:23Sounds like a DataProvider, not a general service class. Or actually like a SelectItemProcessor ?GroupAndSortItemsService.php:25please do not inject LanguageService. We have a LanguageServiceFactory, which creates a languageService depending on the BE User (or whereever you want to use it) -
Nikita Hovratov commented on patch set 4 07/20/23, 11:18
NewMultiplePagesController.php:214ReplyWould make sense together with the renaming below.GroupAndSortItemsService.php:23ReplyNaming is hard, yeah. Right now it only does the "group" and "sorting" thing. If we put more inside like in your comment above, we could rename it to SelectItemProcessor and put it in a Processor folder?GroupAndSortItemsService.php:25ReplyAh ok, I did it, because in the context right now it is taken from $GLOBALS['LANG'] and I wanted the class to be instatiated with GU with the argument provided. -
Nikita Hovratov commented on patch set 4 07/20/23, 11:22
GroupAndSortItemsService.php:25ReplyIs it ok, if we disable autowiring? -
Stefan Bürk uploaded patch set 5
CR -1V +107/21/23, 13:40 -
Stefan Bürk commented on patch set 5 07/21/23, 13:45
NewMultiplePagesController.php:214ReplyBasically ack on moving additional code. However, moving this togheter into a internal class is done as part of a bugfix I tend to do the moving of other code fragements in a dedicated task change afterwards. That way we keep this change to the minimum needed for this bugfix.GroupAndSortItemsService.php:23ReplyDoneGroupAndSortItemsService.php:23ReplyHad the same thinking. Ack on "naming is hard" ;) I took the suggestion from Nikita and pushed it as this. Also adopted it for the introduced test.GroupAndSortItemsService.php:25ReplyI added the LANG with the factory as fallback to the class. Usually, this should be called only from backend context anway. Hope, that's okay for both of you. -
Stefan Bürk uploaded patch set 6 07/21/23, 13:49
-
Stefan Bürk uploaded patch set 7 07/21/23, 13:51
-
core-ci voted on patch set 5 V -1 07/21/23, 13:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44383
-
core-ci voted on patch set 7 V -1 07/21/23, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44386
-
core-ci voted on patch set 6 V -1 07/21/23, 14:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44385
-
Nikita Hovratov uploaded patch set 8
V -107/21/23, 14:59 -
core-ci voted on patch set 8 V +1 07/21/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44393
-
Nikita Hovratov commented on patch set 8 07/21/23, 15:40
NewMultiplePagesController.php:214ReplyAckGroupAndSortItemsService.php:23ReplyDoneGroupAndSortItemsService.php:25ReplyAck -
Stefan Bürk voted on patch set 8 V +1 CR +1 07/21/23, 16:26
-
Benni Mack voted on patch set 8 V +1 CR +1 07/21/23, 17:16
-
Oliver Klee voted on patch set 8 V +1 07/21/23, 18:08
-
Nikita Hovratov voted on patch set 8 V +2 CR +2 07/21/23, 19:10
-
Nikita Hovratov merged patch set 9 07/21/23, 19:10