Review main Merged

80030[TASK] Remove redundant dividers in type select

Nikita Hovratov CR +2 V +2 Easy +0 −35 updated 07/23/23, 07:39

Commit message

The groups and the sorting are already defined in "itemGroups", which
is available since TYPO3 v10. Defining the "--div--" items with the
same group label again is redundant and was only kept to not disturb
other people's TCA after a non dot-zero release.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1820

  1. Nikita Hovratov uploaded patch set 1 07/14/23, 19:20

  2. Nikita Hovratov commented on patch set 1 07/14/23, 19:22

  3. Nikita Hovratov commented on patch set 1 07/14/23, 19:23

  4. core-ci voted on patch set 1 V +1 07/14/23, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44149

  5. Oliver Klee voted on patch set 1 CR +1 07/14/23, 20:14

  6. Nikita Hovratov voted on patch set 1 CR -2 07/15/23, 07:46

  7. Nikita Hovratov commented on patch set 1 07/15/23, 11:08

    @Benni I've read you kept the dividers in v10 for backwards compatibility. Are they safe to be removed now?
  8. Benni Mack commented on patch set 1 07/20/23, 09:21

    Nikita: I can't remember why I kept them, probably because it was after a .0 release and I did not want to disturb people with changing their TCA. One thing though is that we should ensure that we also keep the ordering in sync (I saw you followup btw).
  9. Nikita Hovratov uploaded patch set 2 CR +1 V +1 07/21/23, 19:16

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN")
  10. Nikita Hovratov voted on patch set 2 CR 0 07/21/23, 19:18

  11. core-ci voted on patch set 2 V +1 07/21/23, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44396

  12. Benni Mack commented on patch set 2 07/21/23, 20:58

    we could actually improve this at a later stage: That is: create a TCAmigration that if there are item groups, that --div-- items are removed?
  13. Benni Mack voted on patch set 2 CR +1 07/21/23, 20:58

  14. Oliver Klee voted on patch set 2 CR +1 07/21/23, 20:58

  15. Nikita Hovratov commented on patch set 2 07/21/23, 22:04

    Reply

    Hm, yes we could do that. Should be a rare case, I think.
  16. Benni Mack voted on patch set 2 V +1 07/21/23, 23:44

  17. Stefan Bürk voted on patch set 2 CR +1 07/23/23, 07:20

  18. Stefan Bürk voted on patch set 2 V +1 07/23/23, 07:38

  19. Stefan Bürk voted on patch set 2 V +2 CR +2 07/23/23, 07:38

  20. Stefan Bürk merged patch set 3 07/23/23, 07:39