80030[TASK] Remove redundant dividers in type select
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 2
Review log 1820
-
Nikita Hovratov uploaded patch set 1 07/14/23, 19:20
-
Nikita Hovratov commented on patch set 1 07/14/23, 19:22
Needs pre-patch: https://review.typo3.org/c/Packages/TYPO3.CMS/+/80030 -
Nikita Hovratov commented on patch set 1 07/14/23, 19:23
-
core-ci voted on patch set 1 V +1 07/14/23, 19:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44149
-
Oliver Klee voted on patch set 1 CR +1 07/14/23, 20:14
-
Nikita Hovratov voted on patch set 1 CR -2 07/15/23, 07:46
-
Nikita Hovratov commented on patch set 1 07/15/23, 11:08
@Benni I've read you kept the dividers in v10 for backwards compatibility. Are they safe to be removed now? -
Benni Mack commented on patch set 1 07/20/23, 09:21
Nikita: I can't remember why I kept them, probably because it was after a .0 release and I did not want to disturb people with changing their TCA. One thing though is that we should ensure that we also keep the ordering in sync (I saw you followup btw). -
Nikita Hovratov uploaded patch set 2
CR +1V +107/21/23, 19:16Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR is:MIN") -
Nikita Hovratov voted on patch set 2 CR 0 07/21/23, 19:18
-
core-ci voted on patch set 2 V +1 07/21/23, 19:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44396
-
Benni Mack commented on patch set 2 07/21/23, 20:58
we could actually improve this at a later stage: That is: create a TCAmigration that if there are item groups, that --div-- items are removed? -
Benni Mack voted on patch set 2 CR +1 07/21/23, 20:58
-
Oliver Klee voted on patch set 2 CR +1 07/21/23, 20:58
-
Nikita Hovratov commented on patch set 2 07/21/23, 22:04
Reply
Hm, yes we could do that. Should be a rare case, I think. -
Benni Mack voted on patch set 2 V +1 07/21/23, 23:44
-
Stefan Bürk voted on patch set 2 CR +1 07/23/23, 07:20
-
Stefan Bürk voted on patch set 2 V +1 07/23/23, 07:38
-
Stefan Bürk voted on patch set 2 V +2 CR +2 07/23/23, 07:38
-
Stefan Bürk merged patch set 3 07/23/23, 07:39