Review main Merged

80040[BUGFIX] Avoid exception in redirects module

Torben Hansen CR +2 V +2 Easy +1 −1 updated 07/17/23, 15:49

Commit message

In redirects module it is possible to configure redirects
to records available through the LinkHandler API. This currently
fails with an exception, since the redirects module tries to
resolve the link to the record in the list view. The reason for
this is the `DatabaseRecordLinkBuilder`, which uses the
`frontend.typoscript` attribute from the request object to
retrieve the TypoScript setup. This attribute is not available
in backend context.

This change ensures that the `$typoScriptArray` will fall back
to an empty array if the `frontend.typoscript` request attribute
is not available.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 68

  1. Torben Hansen uploaded patch set 1 07/16/23, 06:06

  2. core-ci voted on patch set 1 V +1 07/16/23, 06:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44184

  3. Oliver Klee updated the commit message in patch set 2 V +1 07/16/23, 08:10

  4. Oliver Klee voted on patch set 2 CR +1 07/16/23, 08:10

  5. core-ci voted on patch set 2 V +1 07/16/23, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44189

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 07/17/23, 11:28

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 07/17/23, 15:49

  8. Stefan Bürk merged patch set 3 07/17/23, 15:49