Review main Merged

80046[TASK] Clean up ext:scheduler details

Christian Kuhn CR +2 V +2 Easy +12 −28 updated 07/17/23, 18:35

Commit message

Resolve a couple of details in ext:scheduler:
* Changing a unit test into a functional test allows us
  declaring SchedulerModuleController final
* Avoid an unused variable and protect a method
* Minor @todo cleanups

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/17/23, 15:57

  2. Christian Kuhn updated the commit message in patch set 2 07/17/23, 16:01

  3. core-ci voted on patch set 1 V +1 07/17/23, 16:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44217

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 07/17/23, 16:08

  5. core-ci voted on patch set 2 V +1 07/17/23, 16:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44218

  6. Oliver Klee voted on patch set 2 V +1 CR +1 07/17/23, 17:16

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/17/23, 18:35

  8. Christian Kuhn merged patch set 3 07/17/23, 18:35