Review 12.4 Merged

80064[TASK] Use later DataHandler hook in `DataHandlerSlugUpdateHook`

Stefan Bürk CR +2 V +2 Easy +4 −4 updated 07/19/23, 22:33

Commit message

Handling the pages slug changed event has been implemented with
a dedicated hook handling class, consuming two DataHandler hooks
to prepare and handle the redirect creation and slug update for
subpages. Auto redirect creation and subpage slug updating are
controlled by site setting configuration options.

The chosen second hook `processDatamap_postProcessFieldArray()`
is executed before the record is persisted into the database.

This change switches to `processDatamap_afterDatabaseOperations()`
as the second hook, so handling code can expect to have the
changes persisted to the database already. For example, this
would allow to use the slug generator in the `updateSlug()`
method in a dedicated change as possible solution for #96928.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 07/19/23, 22:24

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 07/19/23, 22:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44320

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 07/19/23, 22:32

  4. Stefan Bürk merged patch set 2 07/19/23, 22:33