Review main Merged

80078[BUGFIX] Fix fallback icons for custom page types

Nikita Hovratov CR +2 V +2 Easy +3 −3 updated 07/18/23, 15:15

Commit message

Since the introduction of customizable page type icons,
the fallback icons did no longer work. Only the icon
and variations for "contentFromPid" worked. The reason
is, that these icons are prefixed with "page" while the
other ones are prefixed with the doktype ("1").

This is fixed now by providing an optional argument
for the getRecordTypeForPageType method, which takes
the type name as parameter. The default is "1".

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Oliver Klee +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 89

  1. Nikita Hovratov uploaded patch set 1 07/18/23, 11:51

  2. Oliver Klee commented on patch set 1 07/18/23, 11:55

    IconFactory.php:293

    This is a change of the (default) behavior, which looks breaking to me. Maybe we can use 'page' as default value instead, and adapt the callers accordingly. What do you think?
  3. Nikita Hovratov commented on patch set 1 07/18/23, 11:56

    IconFactory.php:293 Reply

    Yes, but it is a bugfix. The default behaviour was broken.
  4. core-ci voted on patch set 1 V +1 07/18/23, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44246

  5. Oliver Klee commented on patch set 1 CR +1 07/18/23, 12:06

    IconFactory.php:293 Reply

    Ack
  6. Christian Kuhn voted on patch set 1 V +1 CR +1 07/18/23, 12:14

  7. Stefan Bürk voted on patch set 1 V +1 CR +1 07/18/23, 12:21

  8. Nikita Hovratov voted on patch set 1 V +2 CR +2 07/18/23, 15:15

  9. Nikita Hovratov merged patch set 2 07/18/23, 15:15