Review main Merged

80082[BUGFIX] Fix incorrect type in RouteDispatcherTest

Oliver Klee CR +2 V +2 Easy +1 −1 updated 07/18/23, 19:04

Commit message

A route option that is missing should either not be set at all, or
it should be `null`, but it will never be `false`.

Simplify the test by removing the missing option altogether to make the
test more minimal.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Oliver Klee uploaded patch set 1 07/18/23, 14:02

  2. core-ci voted on patch set 1 V +1 07/18/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44260

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 07/18/23, 14:18

  4. Oliver Klee updated the commit message in patch set 2 CR +1 V +1 07/18/23, 16:58

  5. core-ci voted on patch set 2 V +1 07/18/23, 17:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44274

  6. Nikita Hovratov voted on patch set 2 CR +1 07/18/23, 18:49

  7. Nikita Hovratov voted on patch set 2 V +1 07/18/23, 18:49

  8. Nikita Hovratov voted on patch set 2 V +2 CR +2 07/18/23, 19:02

  9. Stefan Bürk voted on patch set 2 V +1 CR +1 07/18/23, 19:04

  10. Nikita Hovratov merged patch set 3 07/18/23, 19:04