80084[TASK] Introduce type declarations in StorageRepository
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1926
Show 1 earlier messages
-
Alexander Schnitzler uploaded patch set 1 07/18/23, 14:58
-
core-ci voted on patch set 1 V -1 07/18/23, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44266
-
Alexander Schnitzler uploaded patch set 2
V -107/18/23, 15:50 -
core-ci voted on patch set 2 V +1 07/18/23, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44270
-
Alexander Schnitzler updated the commit message in patch set 3
V +107/20/23, 06:42 -
Alexander Schnitzler marked it ready for review 07/20/23, 06:42
-
Alexander Schnitzler wrote 07/20/23, 06:42
Topic set to FAL -
core-ci voted on patch set 3 V +1 07/20/23, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44329
-
Oliver Klee updated the commit message in patch set 4
V +107/20/23, 07:58 -
Oliver Klee commented on patch set 4 07/20/23, 08:01
StorageRepository.php:229Can we say more about the return value? (My guest would be `positive-int`.)StorageRepository.php:316We can remove this check now (and the corresponding `@throws` annotation).StorageRepository.php:369`@return int<0, max>`, I'd guess. -
core-ci voted on patch set 4 V +1 07/20/23, 08:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44331
-
Alexander Schnitzler uploaded patch set 5
V +107/20/23, 08:13 -
Alexander Schnitzler uploaded patch set 6 07/20/23, 08:15
-
Alexander Schnitzler commented on patch set 6 07/20/23, 08:16
StorageRepository.php:229ReplyNope, lastInsertId might return a falsy value.StorageRepository.php:316ReplyDoneStorageRepository.php:369ReplyDone -
Oliver Klee voted on patch set 6 CR +1 07/20/23, 08:17
-
core-ci voted on patch set 5 V +1 07/20/23, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44333
-
core-ci voted on patch set 6 V +1 07/20/23, 08:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44334
-
Oliver Klee voted on patch set 6 V +1 07/20/23, 08:28
-
Oliver Klee commented on patch set 7
CR +1V +107/20/23, 08:32Published edit on patch set 6. -
Oliver Klee voted on patch set 7 V +1 CR +1 07/20/23, 08:32
-
core-ci voted on patch set 7 V +1 07/20/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44335
-
Stefan Bürk commented on patch set 7 07/21/23, 21:30
StorageRepository.php:37This class neither final nor marked as @internal. I would tend to say that we should consider this class kind of public api which may be extended and used. Therefore, at least the added property type-hint would be "breaking" following casual breaking patch policies. method type-hints (public) should be reconsidered as well. What do you think ? -
Alexander Schnitzler commented on patch set 7 07/22/23, 06:07
StorageRepository.php:37ReplyThis patch is the reason I asked this https://typo3.slack.com/archives/C03AM9R17/p1689835021009679 in the coredev-channel. I first marked it breaking and tried to write a rst file but couldn't come up with any words describing what's actually breaking here. Unless you used the former implementation wrong, those type declarations will not break anything. You can prove me wrong here though. -
Stefan Bürk commented on patch set 7 07/22/23, 07:33
StorageRepository.php:37ReplyDone -
Stefan Bürk voted on patch set 7 V +2 CR +2 07/23/23, 07:17
-
Stefan Bürk merged patch set 8 07/23/23, 07:17