80086[TASK] Add tests for IconFactoryTest fallback page icons
Commit message
Review
-
Code review CR +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
-
Verified V +2 Done
- Nikita Hovratov +2
- Oliver Klee +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 2
Files 1
Review log 1113
-
Nikita Hovratov uploaded patch set 1 07/18/23, 16:23
-
core-ci voted on patch set 1 V +1 07/18/23, 16:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44271
-
Oliver Klee commented on patch set 1 V +1 CR -1 07/18/23, 16:34
-
Nikita Hovratov commented on patch set 1 07/18/23, 16:35
IconFactoryTest.php:60ReplyAh, thanks! -
Nikita Hovratov uploaded patch set 2
CR -1V +107/18/23, 16:35 -
Nikita Hovratov commented on patch set 2 07/18/23, 16:36
IconFactoryTest.php:60ReplyDone -
Oliver Klee commented on patch set 2 07/18/23, 16:40
IconFactoryTest.php:607I'd suggest splitting this into two tests: one for the case where they define their own icons, and one for the case where they don't. (My assumptions is that this test currently covers both kinds of cases, and the "If" in the test name suggests this.) -
core-ci voted on patch set 2 V +1 07/18/23, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44272
-
Nikita Hovratov commented on patch set 2 07/18/23, 16:43
IconFactoryTest.php:607ReplyThese tests are only for the case, where no custom icons are defined. This is enough to prove the regression fix. More tests, which verify that custom icons are indeed loaded could be added later. -
Christian Kuhn voted on patch set 2 V +1 CR +1 07/18/23, 16:45
-
Oliver Klee commented on patch set 2 V +1 CR +1 07/18/23, 16:49
IconFactoryTest.php:607ReplyAck -
Nikita Hovratov voted on patch set 2 V +2 CR +2 07/18/23, 18:54
-
Nikita Hovratov merged patch set 3 07/18/23, 18:54
IconFactoryTest.php:60