80098[!!!][TASK] Remove (get/set)Identifier() from AbstractFile
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Classes/Resource/AbstractFile.php+0 −27
- typo3/sysext/core/Classes/Resource/File.php+8 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php+8 −1
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-101392-GetIdentifierAndSetIdentifierFromAbstractFileRemoved.rst2new+53 −0
- typo3/sysext/core/Tests/Unit/Resource/Fixtures/TestingFile.php2+13 −0
Review log 1521
-
Alexander Schnitzler uploaded patch set 1 07/19/23, 18:26
-
Alexander Schnitzler wrote 07/19/23, 18:26
Topic set to FAL -
core-ci voted on patch set 1 V -1 07/19/23, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44317
-
Benni Mack uploaded patch set 2
V -101/24/24, 10:01 -
core-ci voted on patch set 2 V +1 01/24/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52064
-
Benni Mack marked it ready for review 01/25/24, 13:14
-
Benni Mack rebased onto patch set 3
V +101/25/24, 13:14 -
core-ci voted on patch set 3 V +1 01/25/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52178
-
Simon Schaufelberger commented on patch set 3 01/25/24, 14:46
I think there is only the REST file missing or am i wrong? -
Benni Mack rebased onto patch set 4
V +103/23/25, 13:14 -
core-ci voted on patch set 4 V +1 03/23/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76066
-
Benni Mack uploaded patch set 5
V +103/23/25, 14:53 -
Benni Mack commented on patch set 5 CR +1 V +1 03/23/25, 14:53
Reply
Done -
core-ci voted on patch set 5 V +1 03/23/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76069
-
Simon Schaufelberger commented on patch set 5 03/23/25, 16:27
Breaking-101392-GetIdentifierAndSetIdentifierFromAbstractFileRemoved.rst:14there areTestingFile.php:27empty line after -
Chris Müller commented on patch set 6
CR +1V +103/23/25, 18:11Published edit on patch set 5. -
Chris Müller commented on patch set 6 03/23/25, 18:11
Breaking-101392-GetIdentifierAndSetIdentifierFromAbstractFileRemoved.rst:14ReplyDoneTestingFile.php:27ReplyDone -
core-ci voted on patch set 6 V +1 03/23/25, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76074
-
Benni Mack voted on patch set 6 CR +1 V +1 03/23/25, 19:12
-
Georg Ringer voted on patch set 6 CR +2 V +2 03/23/25, 19:19
-
Georg Ringer merged patch set 7 03/23/25, 19:19