Review main Merged Breaking

80098[!!!][TASK] Remove (get/set)Identifier() from AbstractFile

Alexander Schnitzler CR +2 V +2 Normal +82 −29 updated 03/23/25, 19:19

Commit message

Method getIdentifier() is part of the contract of
ResourceInterface. Contracts should only be fulfilled
by implementations, not by abstract classes.

Reason is, that AbstractFile MUST NOT be api but by
implementing getIdentifier() as an accessor to the
internal property $identifier, it makes the property
in question part of the API.

However, the responsibility to fulfill the contract
is up to the implementation because it gives freedom
to how the contract is fulfilled. A file can store
it's identifier as a string property but it doesn't
need to. Other implementations might use a stringable
object to represent the identifier and AbstractFile
did prevent this.

Hence, all implementations do now take care of handling
their identifiers themselve. And only those Files that
allow to mutate their identifier will provide those in
form of a setter or otherwise.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1521

  1. Alexander Schnitzler uploaded patch set 1 07/19/23, 18:26

  2. Alexander Schnitzler wrote 07/19/23, 18:26

    Topic set to FAL
  3. core-ci voted on patch set 1 V -1 07/19/23, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44317

  4. Benni Mack uploaded patch set 2 V -1 01/24/24, 10:01

  5. core-ci voted on patch set 2 V +1 01/24/24, 10:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52064

  6. Benni Mack marked it ready for review 01/25/24, 13:14

  7. Benni Mack rebased onto patch set 3 V +1 01/25/24, 13:14

  8. core-ci voted on patch set 3 V +1 01/25/24, 13:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52178

  9. Simon Schaufelberger commented on patch set 3 01/25/24, 14:46

    I think there is only the REST file missing or am i wrong?
  10. Benni Mack rebased onto patch set 4 V +1 03/23/25, 13:14

  11. core-ci voted on patch set 4 V +1 03/23/25, 13:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76066

  12. Benni Mack uploaded patch set 5 V +1 03/23/25, 14:53

  13. Benni Mack commented on patch set 5 CR +1 V +1 03/23/25, 14:53

    Reply

    Done
  14. core-ci voted on patch set 5 V +1 03/23/25, 15:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76069

  15. Simon Schaufelberger commented on patch set 5 03/23/25, 16:27

    Breaking-101392-GetIdentifierAndSetIdentifierFromAbstractFileRemoved.rst:14

    there are

    TestingFile.php:27

    empty line after
  16. Chris Müller commented on patch set 6 CR +1 V +1 03/23/25, 18:11

    Published edit on patch set 5.
  17. Chris Müller commented on patch set 6 03/23/25, 18:11

    Breaking-101392-GetIdentifierAndSetIdentifierFromAbstractFileRemoved.rst:14 Reply

    Done

    TestingFile.php:27 Reply

    Done
  18. core-ci voted on patch set 6 V +1 03/23/25, 18:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76074

  19. Benni Mack voted on patch set 6 CR +1 V +1 03/23/25, 19:12

  20. Georg Ringer voted on patch set 6 CR +2 V +2 03/23/25, 19:19

  21. Georg Ringer merged patch set 7 03/23/25, 19:19