Review main Merged

80105[TASK] Simplify mapObjectToClassProperty with early returns

Alexander Schnitzler CR +2 V +2 Normal +33 −33 updated 07/23/23, 07:21

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Alexander Schnitzler uploaded patch set 1 07/21/23, 06:36

  2. Alexander Schnitzler uploaded patch set 2 07/21/23, 06:40

  3. Alexander Schnitzler wrote 07/21/23, 06:40

    Topic set to extbase
  4. core-ci voted on patch set 1 V +1 07/21/23, 06:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44364

  5. core-ci voted on patch set 2 V +1 07/21/23, 06:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44365

  6. Alexander Schnitzler marked it ready for review 07/21/23, 06:51

  7. Oliver Klee voted on patch set 2 V +1 07/21/23, 07:50

  8. Oliver Klee voted on patch set 2 CR +1 07/21/23, 07:51

  9. Stefan Bürk commented on patch set 2 V +1 CR +1 07/21/23, 20:58

    Good for me, Markus added himself as reviewer - so I wait a little for a response before merging it.
  10. Stefan Bürk voted on patch set 2 V +2 CR +2 07/23/23, 07:21

  11. Stefan Bürk merged patch set 3 07/23/23, 07:21