Review main Merged

80108[TASK] Simplify DataMapper::getPlainValue()

Alexander Schnitzler CR +2 V +2 Normal +37 −34 updated 02/13/25, 21:37

Commit message

Use early returns to remove if..else cascades which
are hard to read.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1115

  1. Alexander Schnitzler uploaded patch set 1 07/21/23, 10:25

  2. Alexander Schnitzler wrote 07/21/23, 10:26

    Topic set to extbase
  3. Alexander Schnitzler uploaded patch set 2 07/21/23, 10:27

  4. core-ci voted on patch set 1 V -1 07/21/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44372

  5. Alexander Schnitzler uploaded patch set 3 07/21/23, 10:38

  6. core-ci voted on patch set 2 V -1 07/21/23, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44373

  7. core-ci voted on patch set 3 V -1 07/21/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44374

  8. Alexander Schnitzler uploaded patch set 4 V -1 07/21/23, 11:26

  9. core-ci voted on patch set 4 V +1 07/21/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44376

  10. Alexander Schnitzler marked it ready for review 07/21/23, 11:37

  11. Oliver Klee voted on patch set 4 V +1 CR +1 07/21/23, 12:06

  12. Stefan Bürk voted on patch set 4 V +2 CR +2 07/21/23, 20:54

  13. Stefan Bürk merged patch set 5 07/21/23, 20:54

  14. Benni Mack commented on patch set 5 02/13/25, 10:23

    DataMapper.php:855

    calling $input->_loadRealInstance() might return null|object - what I don't understand is how a) why we did not consider this in the method signature b) we don't have tests for this case (LazyLoadingProxy) that might fail
  15. Benni Mack commented on patch set 5 02/13/25, 21:37

    DataMapper.php:855 Reply

    sorry, this was a oversight of mine. thanks, alex.