80108[TASK] Simplify DataMapper::getPlainValue()
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oliver Klee +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oliver Klee +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1115
-
Alexander Schnitzler uploaded patch set 1 07/21/23, 10:25
-
Alexander Schnitzler wrote 07/21/23, 10:26
Topic set to extbase -
Alexander Schnitzler uploaded patch set 2 07/21/23, 10:27
-
core-ci voted on patch set 1 V -1 07/21/23, 10:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44372
-
Alexander Schnitzler uploaded patch set 3 07/21/23, 10:38
-
core-ci voted on patch set 2 V -1 07/21/23, 10:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44373
-
core-ci voted on patch set 3 V -1 07/21/23, 10:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44374
-
Alexander Schnitzler uploaded patch set 4
V -107/21/23, 11:26 -
core-ci voted on patch set 4 V +1 07/21/23, 11:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44376
-
Alexander Schnitzler marked it ready for review 07/21/23, 11:37
-
Oliver Klee voted on patch set 4 V +1 CR +1 07/21/23, 12:06
-
Stefan Bürk voted on patch set 4 V +2 CR +2 07/21/23, 20:54
-
Stefan Bürk merged patch set 5 07/21/23, 20:54
-
Benni Mack commented on patch set 5 02/13/25, 10:23
DataMapper.php:855calling $input->_loadRealInstance() might return null|object - what I don't understand is how a) why we did not consider this in the method signature b) we don't have tests for this case (LazyLoadingProxy) that might fail -
Benni Mack commented on patch set 5 02/13/25, 21:37
DataMapper.php:855Replysorry, this was a oversight of mine. thanks, alex.