Review main Abandoned Breaking

80125[!!!][TASK] Remove `TYPO3.Notification`

Andreas Kienast CR 0 V 0 Normal +73 −43 updated 08/03/23, 18:52

Commit message

The accessor `TYPO3.Notification` was introduced in TYPO3 v7 to ease
the use of said module when module loading was not well established
back then. Using this relies on having the module already loaded
before, which may not always be the case, e.g. when not using the
ModuleTemplate API. Additionally, using the shortcut may lead to CSP
issues in some scenarios.

Since it is recommended to use proper modules in any way,
`TYPO3.Notification` has been removed along with the default import of
the module from the ModuleTemplate API.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 5

Review log 46

  1. Andreas Kienast uploaded patch set 1 07/24/23, 07:28

  2. core-ci voted on patch set 1 V -1 07/24/23, 07:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44455

  3. Andreas Kienast uploaded patch set 2 V -1 07/24/23, 11:30

  4. Andreas Kienast commented on patch set 2 CR -2 07/24/23, 11:33

    Needs more rework - when a notification is rendered, the underlying handling is bound to the document it was called in. When switching the module while any notification is available it's not possible to close it anymore.
  5. core-ci voted on patch set 2 V -1 07/24/23, 11:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44467

  6. Andreas Kienast abandoned the change 08/03/23, 18:52

    Not possible right now