Review main Merged

80128[BUGFIX] Properly iterate over extensions in extension manager

Elias Häußler CR +2 V +2 Easy +22 −11 updated 11/24/23, 11:57

Commit message

When downloading or updating extension using extension manager, the
resulting extensions are now properly iterated using `Object.keys`.
This is necessary since the extensions are provided as objects instead
of simple arrays.

In addition, the relevant methods in ExtensionManagementService now
have proper type declarations and annotations.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1114

  1. Elias Häußler uploaded patch set 1 07/24/23, 12:31

  2. core-ci voted on patch set 1 V +1 07/24/23, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44468

  3. Benni Mack voted on patch set 1 CR +1 07/24/23, 14:47

  4. Stefan Bürk commented on patch set 1 07/24/23, 21:25

    DownloadController.php:285

    The added array for 0 should get the array shape added to the managementService->installExtension return type in the other class.
  5. Elias Häußler uploaded patch set 2 CR +1 V +1 07/25/23, 06:26

  6. Elias Häußler commented on patch set 2 07/25/23, 06:26

    DownloadController.php:285 Reply

    Done
  7. core-ci voted on patch set 2 V +1 07/25/23, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44494

  8. Benni Mack commented on patch set 2 11/24/23, 08:57

    Hey Elias, can you rebase this one?
  9. Elias Häußler uploaded patch set 3 V +1 11/24/23, 09:26

  10. core-ci voted on patch set 3 V +1 11/24/23, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49856

  11. Jochen Roth voted on patch set 3 CR +1 V +1 11/24/23, 10:16

  12. Andreas Kienast voted on patch set 3 CR +1 V +1 11/24/23, 11:48

  13. Andreas Kienast voted on patch set 3 CR +2 V +2 11/24/23, 11:49

  14. Andreas Kienast merged patch set 4 11/24/23, 11:57