Review main Merged

80129[BUGFIX] Add missing `Icon::SIZE_MEGA` constant

Andreas Kienast CR +2 V +2 Normal +51 −0 updated 07/25/23, 11:52

Commit message

The Icon API in general knows the icon size "mega", which renders an
icon in the dimensions 64x64. However, the according constant was absent
in the `Icon` class, which is now added.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Jasmina Ließmann +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1720

  1. Andreas Kienast uploaded patch set 1 07/24/23, 13:58

  2. Oliver Klee voted on patch set 1 CR +1 07/24/23, 14:06

  3. core-ci voted on patch set 1 V +1 07/24/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44473

  4. Jasmina Ließmann voted on patch set 1 CR +1 07/24/23, 14:33

  5. Benjamin Franzke voted on patch set 1 V +1 CR +1 07/24/23, 15:55

  6. Stefan Bürk commented on patch set 1 CR -1 07/24/23, 21:33

    Icon.php:196

    `Dimension::class` does not support the "mega" size and will throw a exception if setSize is called with `SIZE_MEGA` Not checked for furter places, but I guess this should be adopted along when adding the constant. I'd say the "support" was not fully there then - or does I stepped into a trap ?
  7. Andreas Kienast commented on patch set 1 07/25/23, 05:56

    Icon.php:196 Reply

    Ack
  8. Andreas Kienast uploaded patch set 2 CR +1 V +1 07/25/23, 06:04

  9. Andreas Kienast commented on patch set 2 07/25/23, 06:09

    IconTest.php:99

    Yes, the test smells. Looking forward having an enum here.
  10. core-ci voted on patch set 2 V +1 07/25/23, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44493

  11. Andreas Kienast commented on patch set 2 07/25/23, 06:28

    IconTest.php:99 Reply

    Done
  12. Stefan Bürk voted on patch set 2 V +1 CR +1 07/25/23, 09:58

  13. Christian Kuhn commented on patch set 2 07/25/23, 11:38

    IconTest.php:88

    hey. we have the habit to have DP's before the actual test. i'll swap this.
  14. Christian Kuhn uploaded patch set 3 CR +1 V +1 07/25/23, 11:42

  15. Christian Kuhn voted on patch set 3 V +1 CR +1 07/25/23, 11:43

  16. Jasmina Ließmann voted on patch set 3 CR +1 07/25/23, 11:45

  17. Stefan Bürk voted on patch set 3 V +1 CR +1 07/25/23, 11:46

  18. core-ci voted on patch set 3 V +1 07/25/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44519

  19. Andreas Kienast voted on patch set 3 V +2 CR +2 07/25/23, 11:52

  20. Andreas Kienast merged patch set 4 07/25/23, 11:52