80129[BUGFIX] Add missing `Icon::SIZE_MEGA` constant
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Jasmina Ließmann +1
- Stefan Bürk +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Stefan Bürk +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1720
-
Andreas Kienast uploaded patch set 1 07/24/23, 13:58
-
Oliver Klee voted on patch set 1 CR +1 07/24/23, 14:06
-
core-ci voted on patch set 1 V +1 07/24/23, 14:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44473
-
Jasmina Ließmann voted on patch set 1 CR +1 07/24/23, 14:33
-
Benjamin Franzke voted on patch set 1 V +1 CR +1 07/24/23, 15:55
-
Stefan Bürk commented on patch set 1 CR -1 07/24/23, 21:33
-
Andreas Kienast commented on patch set 1 07/25/23, 05:56
Icon.php:196ReplyAck -
Andreas Kienast uploaded patch set 2
CR +1V +107/25/23, 06:04 -
Andreas Kienast commented on patch set 2 07/25/23, 06:09
IconTest.php:99Yes, the test smells. Looking forward having an enum here. -
core-ci voted on patch set 2 V +1 07/25/23, 06:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44493
-
Andreas Kienast commented on patch set 2 07/25/23, 06:28
IconTest.php:99ReplyDone -
Stefan Bürk voted on patch set 2 V +1 CR +1 07/25/23, 09:58
-
Christian Kuhn commented on patch set 2 07/25/23, 11:38
IconTest.php:88hey. we have the habit to have DP's before the actual test. i'll swap this. -
Christian Kuhn uploaded patch set 3
CR +1V +107/25/23, 11:42 -
Christian Kuhn voted on patch set 3 V +1 CR +1 07/25/23, 11:43
-
Jasmina Ließmann voted on patch set 3 CR +1 07/25/23, 11:45
-
Stefan Bürk voted on patch set 3 V +1 CR +1 07/25/23, 11:46
-
core-ci voted on patch set 3 V +1 07/25/23, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44519
-
Andreas Kienast voted on patch set 3 V +2 CR +2 07/25/23, 11:52
-
Andreas Kienast merged patch set 4 07/25/23, 11:52
Icon.php:196