Review 11.5 Merged

80138[TASK] Improve return type annotations for GU::trimExplode

Oliver Klee CR +2 V +2 Easy +5 −2 updated 07/25/23, 14:08

Commit message

This particularly helps PHPStan in extensions that call those methods
detect unnecessary checks for empty strings if
`GU::trimExplode` is called with `$removeEmptyValues = true`.

Used command:

> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 3