80169[BUGFIX] Properly bind parameters to statement in upgrade wizard
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1214
-
Elias Häußler uploaded patch set 1 07/25/23, 14:11
-
core-ci voted on patch set 1 V +1 07/25/23, 14:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44542
-
Stefan Bürk commented on patch set 1 CR -1 07/25/23, 14:26
-
Stefan Bürk commented on patch set 1 07/25/23, 14:29
SysLogChannel.php:60ReplyChange below "similar" not the same .. Correct here complete should be: ``` $statement->bind(0, $channel, Connection::PARAM_STR); $statement->bind(1, $type, Connection::PARAM_INT); $statement->executeStatement(); ```SysLogChannel.php:82Don't reverte to deprecated doctrine/dbal api please. The correct fix should be: ``` $statement->bind(0, $level, Connection::PARAM_STR); $statement->bind(1, $type, Connection::PARAM_INT); $statement->executeStatement(); ``` -
Elias Häußler commented on patch set 1 07/25/23, 14:33
SysLogChannel.php:60ReplyThat's what I did first. However, it does not work either: > Uncaught TYPO3 Exception The number of elements in the type definition string must match the number of bind variables > thrown in file /var/www/html/app/vendor/doctrine/dbal/src/Driver/Mysqli/Statement.php > in line 196 -
Elias Häußler commented on patch set 1 07/25/23, 14:42
SysLogChannel.php:60ReplyAh, I see, it starts counting from 1. Will update the patch accordingly. -
Stefan Bürk commented on patch set 1 07/25/23, 14:43
SysLogChannel.php:60Replyah yes .. sry .. not looked up again. was just out of mind. -
Elias Häußler uploaded patch set 2
CR -1V +107/25/23, 14:47 -
Elias Häußler commented on patch set 2 07/25/23, 14:48
SysLogChannel.php:60ReplyDoneSysLogChannel.php:82ReplyDone -
core-ci voted on patch set 2 V +1 07/25/23, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44543
-
Stefan Bürk voted on patch set 2 V +1 CR +1 07/25/23, 20:03
-
Stefan Bürk commented on patch set 2 07/25/23, 20:05
broke in v12 only, main upgrade wizard have been already remove due to policy. v11 has working state. -
Christian Kuhn voted on patch set 2 V +2 CR +2 07/28/23, 18:26
-
Christian Kuhn merged patch set 3 07/28/23, 18:26
SysLogChannel.php:60