Review main Merged

80175[BUGFIX] Load importmaps for external form backend module scripts

Benjamin Franzke CR +2 V +2 Easy +3 −1 updated 07/28/23, 09:40

Commit message

The form migration to ES6 modules in #96568
missed to pre-register importmaps of third
party extensions.
The modules are loaded on initial request
via `import()`, but that requires an importmap
definition for external modules.

The modules are now preloaded in order to make
them available for dynamic imports.
Note that the modules are loaded by the form editor
and manager on initial load anyway, therefore it is
considered "ok" to preload the modules directly.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan P +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan P +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Benjamin Franzke uploaded patch set 1 07/26/23, 05:29

  2. Benjamin Franzke commented on patch set 1 07/26/23, 05:30

    Can be tested via following fork of a public extension: https://github.com/bnf/form_element_linked_checkbox/commit/esm-modules
  3. core-ci voted on patch set 1 V +1 07/26/23, 05:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44566

  4. Stefan P commented on patch set 1 V +1 CR +1 07/26/23, 05:51

    Works for me, thank you.
  5. Benjamin Franzke wrote 07/26/23, 13:55

    Topic set to esm
  6. Oli Bartsch voted on patch set 1 V +2 CR +2 07/28/23, 09:40

  7. Oli Bartsch merged patch set 2 07/28/23, 09:40