80177[BUGFIX] Fix return type annotation for GU::explodeUrl2Array
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Thomas Hohn +1
- Torben Hansen +1
- Alexander Schnitzler +1
- Oliver Hader +1
-
Verified V +2 Done
- Christian Kuhn +2
- Torben Hansen +1
- Alexander Schnitzler +1
- Oliver Hader +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1215
-
Oliver Klee uploaded patch set 1 07/26/23, 07:46
-
core-ci voted on patch set 1 V +1 07/26/23, 07:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44569
-
Oliver Hader commented on patch set 1 CR -1 07/26/23, 10:27
Should it be `array<array-key, ...>` instead of `array<string|int, ...>`? (see https://github.com/phpstan/phpstan/issues/2591) Where does it cause trouble currently (probably in PHPStan)? -
Oliver Klee commented on patch set 1 07/26/23, 10:35
Reply
`array<array-key, ...` and `array<string|int, ...>` are semantically the same, and I'd be fine with either (whatever helps getting this change merged). ;-) Currently, it's not causing trouble with PHPStan (at least not with our current PHPStan level). It will however cause trouble if code relies on the array keys being strings and then e.g. uses the array keys as arguments to `str_contains` in a PHP file in strict mode. This change here will help PHPStan catch those cases (and it will also help the dev reading the type declaration). -
Oliver Klee uploaded patch set 2
CR -1V +107/26/23, 10:46 -
Oliver Klee commented on patch set 2 07/26/23, 10:46
Reply
Done. -
core-ci voted on patch set 2 V +1 07/26/23, 10:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44574
-
Oliver Klee rebased onto patch set 3
V +107/26/23, 20:00 -
core-ci voted on patch set 3 V +1 07/26/23, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44595
-
Oliver Hader voted on patch set 3 V +1 CR +1 07/26/23, 20:28
-
Torben Hansen voted on patch set 3 V +1 CR +1 07/27/23, 06:37
-
Thomas Hohn voted on patch set 3 CR +1 07/27/23, 13:38
-
Alexander Schnitzler voted on patch set 3 V +1 CR +1 07/27/23, 13:44
-
Christian Kuhn voted on patch set 3 V +2 CR +2 07/28/23, 08:12
-
Christian Kuhn merged patch set 4 07/28/23, 08:12