80179[TASK] Add CSP handler for Facebook In-App-Browser
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/80179/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/80179/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
Issues 1
Files 3
Review log 911
-
Oliver Hader uploaded patch set 1 07/26/23, 15:27
-
core-ci voted on patch set 1 V -1 07/26/23, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44586
-
Oliver Hader uploaded patch set 2
V -107/26/23, 15:40 -
core-ci voted on patch set 2 V +1 07/26/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44587
-
Christian Kuhn voted on patch set 2 V +1 CR +1 07/28/23, 19:49
-
Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 19:50
-
Jörg Bösche commented on patch set 2 CR -1 08/10/23, 13:11
-
Oliver Hader wrote 08/30/23, 15:33
Topic set to csp -
Oliver Hader marked it work in progress 10/18/23, 15:00
-
Oliver Hader updated the commit message in patch set 3
CR +1V +110/18/24, 14:10 -
Garvin Hicking commented on patch set 3 01/24/25, 19:07
This patch here feels a bit like it should be an extension, and the possiblity to do so offered by Core PSR events? Doing this specifically for Facebook (even though it's big) and them changing their endpoints/URIs at any moment, maintaining this in the core would feel odd? For an extension this might be better to handle with intermediate updates and add other kinds of services too. Haven't checked too thoroughly, maybe it would already even be possible to do this with current Core implementation?!
FacebookInAppBrowserHandler.php:54Unresolved