Review main Work in progress Orphaned

80179[TASK] Add CSP handler for Facebook In-App-Browser

Oliver Hader CR 0 V 0 Normal +104 −3 updated 01/24/25, 19:07

Commit message

In case the In-App-Browser of the Facebook app is used to
view a website that has content-security-policy enabled,
there might be violation reports about blocked URIs, that
were actually not used on the website.

These reports might be confusing for website admins, but
also might have a negative impact for regular visitors
when clicking on items in the Facebook or Instagram apps.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/80179/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/79/80179/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote

Issues 1

Files 3

Review log 911

  1. Oliver Hader uploaded patch set 1 07/26/23, 15:27

  2. core-ci voted on patch set 1 V -1 07/26/23, 15:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44586

  3. Oliver Hader uploaded patch set 2 V -1 07/26/23, 15:40

  4. core-ci voted on patch set 2 V +1 07/26/23, 15:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44587

  5. Christian Kuhn voted on patch set 2 V +1 CR +1 07/28/23, 19:49

  6. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 19:50

  7. Jörg Bösche commented on patch set 2 CR -1 08/10/23, 13:11

    FacebookInAppBrowserHandler.php:54 Unresolved

    We shouldn't check the locale information of the uri. On german websites, you might have the locale string in the uri. "https://connect.facebook.net/de_DE/"; See also: https://developers.facebook.com/docs/javascript/internationalization/
  8. Oliver Hader wrote 08/30/23, 15:33

    Topic set to csp
  9. Oliver Hader marked it work in progress 10/18/23, 15:00

  10. Oliver Hader updated the commit message in patch set 3 CR +1 V +1 10/18/24, 14:10

  11. Garvin Hicking commented on patch set 3 01/24/25, 19:07

    This patch here feels a bit like it should be an extension, and the possiblity to do so offered by Core PSR events? Doing this specifically for Facebook (even though it's big) and them changing their endpoints/URIs at any moment, maintaining this in the core would feel odd? For an extension this might be better to handle with intermediate updates and add other kinds of services too. Haven't checked too thoroughly, maybe it would already even be possible to do this with current Core implementation?!