Review main Merged

80182[BUGFIX] npm: update vulnerable dev dependencies

Andreas Kienast CR +2 V +2 Hard +216 −238 updated 07/28/23, 16:54

Commit message

Some dev dependencies have known security issues again, that are now
updated.

Executed command:

    npm audit fix --force

Due to the required update to PostCSS v8, the package `autoprefixer` is
updated to v10 as well.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1113

  1. Andreas Kienast uploaded patch set 1 07/27/23, 06:32

  2. Andreas Kienast updated the commit message in patch set 2 07/27/23, 06:33

  3. Benjamin Franzke commented on patch set 2 CR -1 07/27/23, 06:40

    CR-1, to hold for a second. So postcss-clean needs to be downgraded because 1.2.2 has a security vulnerability that is not yet fixed? would like to check
  4. core-ci voted on patch set 2 V +1 07/27/23, 06:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44602

  5. Oliver Hader commented on patch set 2 07/27/23, 08:48

    The problem is in `postcss`: * `postcss-clean 1.2.2` requires `postcss ^6.x` * `postcss-clean 1.2.0` required `postcss ^8.x` However, that really feels strange, that a newer version of `postcss-clean` requires an older version of `postcss`...
  6. Oliver Hader commented on patch set 2 07/27/23, 09:06

    Adding `overrides` to `package.json` might solve this, without downgrading `postcss-clean`. ``` "overrides": { "postcss": "^8.4" } ``` Then, the build process failed for me locally since the plugin is not compatible to v8.x of `postcss` (see https://github.com/leodido/postcss-clean/pull/71/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519). Fun! 🎉
  7. Andreas Kienast uploaded patch set 3 CR -1 V +1 07/28/23, 13:12

  8. core-ci voted on patch set 3 V +1 07/28/23, 13:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44674

  9. Benjamin Franzke voted on patch set 3 V +1 CR +1 07/28/23, 13:27

  10. Andreas Kienast commented on patch set 3 07/28/23, 16:53

    Reply

    Done

    Reply

    merci, solved by updating autoprefixer.
  11. Christian Kuhn voted on patch set 3 V +1 CR +1 07/28/23, 16:54

  12. Andreas Kienast voted on patch set 3 V +2 CR +2 07/28/23, 16:54

  13. Andreas Kienast merged patch set 4 07/28/23, 16:54