Merge conflict Gerrit cannot merge this change. It needs a rebase onto main.
80187[!!!][TASK] Use php cache frontend for ClassSchema cache entries
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/87/80187/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/87/80187/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Issues 1
Files 7
- typo3/sysext/core/Configuration/DefaultConfiguration.php+8 −0
- typo3/sysext/core/Documentation/Changelog/14.0/Breaking-101461-UsePhpCacheFrontendForClassSchemaCacheEntries.rstnew+59 −0
- typo3/sysext/extbase/Classes/Reflection/ReflectionService.php7+75 −50
- typo3/sysext/extbase/Classes/ServiceProvider.php+1 −3
- typo3/sysext/extbase/Tests/Unit/Mvc/View/JsonViewTest.php+3 −3
- typo3/sysext/extbase/Tests/Unit/Reflection/ObjectAccessTest.php+4 −4
- typo3/sysext/extbase/Tests/Unit/Reflection/ReflectionServiceTest.php+5 −5
Review log 2025
-
Alexander Schnitzler uploaded patch set 1 07/27/23, 13:41
-
Alexander Schnitzler wrote 07/27/23, 13:41
Topic set to extbase -
core-ci voted on patch set 1 V -1 07/27/23, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44618
-
Alexander Schnitzler uploaded patch set 2
V -107/28/23, 09:35 -
core-ci voted on patch set 2 V -1 07/28/23, 09:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44662
-
Alexander Schnitzler uploaded patch set 3
V -107/28/23, 10:13 -
core-ci voted on patch set 3 V +1 07/28/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44664
-
Alexander Schnitzler uploaded patch set 4
V +107/28/23, 12:00 -
core-ci voted on patch set 4 V +1 07/28/23, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44669
-
Alexander Schnitzler marked it ready for review 07/28/23, 12:08
-
Oliver Klee commented on patch set 4 07/28/23, 12:50
ReflectionService.php:42UnresolvedCan/Should the elements be `non-empty-string`?ReflectionService.php:95class-string -
Oliver Klee commented on patch set 4 07/28/23, 13:00
And just so this doesn’t go missing: I think this approach really makes sense and is a good direction to go in! <3 -
Christian Kuhn commented on patch set 4 07/28/23, 18:24
unsure on this one, needs proper review and maybe detail discussion. -
Oliver Klee commented on patch set 4 08/07/23, 13:57
Reply
Done -
Oliver Klee voted on patch set 4 V +1 08/07/23, 13:58
-
Oliver Klee commented on patch set 4 10/08/23, 13:34
How should we proceed here? -
Simon Schaufelberger commented on patch set 4 01/25/24, 14:28
Reply
@git@alexanderschnitzler.de Will this make it for v13? -
Alexander Schnitzler commented on patch set 4 01/25/24, 14:39
Reply
Well, I don't see what I need to do here. From my perspective a core merger needs to review, +2 and merge. So, don't ask me, ask the gods. ;) -
Simon Schaufelberger commented on patch set 4 01/25/24, 15:30
Reply Unresolved
This will probably only be merged if there are no more unresolved comments. That is why I'm asking. Do you want to finish it so it can be merged? -
Stefan Bürk commented on patch set 4 01/26/24, 08:38
TBH - not really sure about the impact splitting it or not, but at least there are questions open.ReflectionService.php:37UnresolvedInstead of a class internal state, would it not be possible to use a runtime cache beside the slower phpfrontend cache ?ReflectionService.php:44UnresolvedDo we really need this identifier cache ? it's neither serialized/deserialized and only used exactly once - if it's not in the internal (runtime cache) it's calculated one time per request based on the classname to check if it is in the slow filebased cache or create it and save it. No need to collect a long list of identifier mapping here. Or do I miss something ?ReflectionService.php:111UnresolvedDo we really need that identifier schema - or would be a generic "class-schema-" prefix sufficient along with the xxh3 hash value ? However, does not really harm.ReflectionService.php:134UnresolvedDoes this class really needs to be serializable/deserializable ? There are no setter to set the needed values (cache service) again - or is the constructor missued and called manually after deserialization ? -
Alexander Schnitzler commented on patch set 4 01/31/24, 20:20
Reply
Well, 6 months ago I could have easily answered your question. Now, I neither found the time nor the will to dig into it super quick for 13. I'd say, someone should take over or we just abandon this patch. I don't have time for this, at all. And I won't have any free time anytime soon to be more active again. -
Simon Schaufelberger uploaded patch set 5
V +111/07/25, 17:22 -
Simon Schaufelberger commented on patch set 4 11/07/25, 17:23
ReflectionService.php:95ReplyDone -
core-ci voted on patch set 5 V -1 11/07/25, 17:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/88661
-
Christian Kuhn wrote 06/18/26, 23:05
Removed cc Christian Kuhn.