Review main Merged

80190[TASK] Remove superfluous language service usage in ext:install

Torben Hansen CR +2 V +2 Easy +0 −4 updated 07/28/23, 07:53

Commit message

The usage of `LanguageServiceFactory` in `SetupDatabaseService`
can safely be removed, since it is not required to initialize
`$GLOBALS['LANG']` in order to localize password policy validation
messages.

Since #97390 the `AbstractPasswordValidator` takes care of initializing
the `LanguageService` and localizes possible password policy validation
error messages.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 914

  1. Torben Hansen uploaded patch set 1 07/27/23, 17:26

  2. core-ci voted on patch set 1 V -1 07/27/23, 17:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44622

  3. Torben Hansen uploaded patch set 2 V -1 07/27/23, 17:48

  4. core-ci voted on patch set 2 V +1 07/27/23, 17:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44625

  5. Stefan Bürk updated the commit message in patch set 3 V +1 07/27/23, 19:26

  6. Stefan Bürk updated the commit message in patch set 4 07/27/23, 19:26

  7. Stefan Bürk updated the commit message in patch set 5 07/27/23, 19:27

  8. core-ci voted on patch set 4 V +1 07/27/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44628

  9. core-ci voted on patch set 3 V +1 07/27/23, 19:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44627

  10. core-ci voted on patch set 5 V +1 07/27/23, 19:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44629

  11. Stefan Bürk voted on patch set 5 CR +1 07/27/23, 19:45

  12. Stefan Bürk voted on patch set 5 V +1 07/27/23, 20:21

  13. Christian Kuhn voted on patch set 5 V +2 CR +2 07/28/23, 07:53

  14. Christian Kuhn merged patch set 6 07/28/23, 07:53