80192[TASK] Reactivate usage of constructable stylesheets for icon element
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Andreas Kienast +1
- Benjamin Kott +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1216
-
Benjamin Franzke uploaded patch set 1 07/27/23, 19:56
-
Benjamin Franzke wrote 07/27/23, 19:56
Topic set to lit -
Benjamin Franzke updated the commit message in patch set 2 07/27/23, 19:59
-
core-ci voted on patch set 1 V +1 07/27/23, 20:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44630
-
core-ci voted on patch set 2 V +1 07/27/23, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44631
-
Benjamin Franzke commented on patch set 2 CR -1 07/27/23, 20:39
Blocking this myself for now in order to await feedback by Benji – cause here filed https://forge.typo3.org/issues/100270 -
Benjamin Franzke uploaded patch set 3 07/28/23, 08:31
Copied Votes: * Code-Review-1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified+1 (copy condition: "changekind:NO_CHANGE") -
core-ci voted on patch set 3 V +1 07/28/23, 08:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44658
-
Benjamin Kott commented on patch set 3 V +1 CR +1 07/28/23, 09:01
cannot reproduce the original issue anymore. as mentioned in the introducing patch it was a workaround since this variant produced the error. -
Benjamin Franzke uploaded patch set 4
CR +1V +107/28/23, 09:02 -
Benjamin Kott voted on patch set 4 V +1 CR +1 07/28/23, 09:03
-
Benjamin Kott commented on patch set 4 07/28/23, 09:03
Reply
Done -
core-ci voted on patch set 4 V +1 07/28/23, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44660
-
Andreas Kienast voted on patch set 4 V +1 CR +1 07/28/23, 12:59
-
Benjamin Franzke voted on patch set 4 V +2 CR +2 07/28/23, 17:02
-
Benjamin Franzke merged patch set 5 07/28/23, 17:02