Review main Merged

80193[TASK] Consolidate COR->typolink() tests

Christian Kuhn CR +2 V +2 Expert +666 −892 updated 07/28/23, 07:43

Commit message

ContentObjectRenderer->typolink() is covered by
both unit and functional tests with partially
overlapping sets and - of course - incomplete and
extensive mocking in unit tests.

The patch merges unit tests into functionals,
renames and consolidates a bit.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/28/23, 05:42

  2. core-ci voted on patch set 1 V +1 07/28/23, 05:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44635

  3. Christian Kuhn uploaded patch set 2 V +1 07/28/23, 06:09

  4. core-ci voted on patch set 2 V +1 07/28/23, 06:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44639

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 06:38

  6. Andreas Kienast voted on patch set 2 V +1 CR +1 07/28/23, 07:21

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/28/23, 07:43

  8. Christian Kuhn merged patch set 3 07/28/23, 07:43