80195[TASK] Introduce type declarations in LocalPath
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Files 1
Review log 910
-
Alexander Schnitzler uploaded patch set 1 07/28/23, 06:40
-
Alexander Schnitzler wrote 07/28/23, 06:45
Topic set to FAL -
core-ci voted on patch set 1 V +1 07/28/23, 06:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44642
-
Alexander Schnitzler marked it ready for review 07/28/23, 07:01
-
Oliver Klee commented on patch set 1 07/28/23, 07:57
LocalPath.php:35This needs a default value, as there is a path in `__construct` where it is not set. -
Alexander Schnitzler commented on patch set 1 07/28/23, 08:02
LocalPath.php:35ReplyWhat path would that be? -
Oliver Klee commented on patch set 1 V +1 CR +1 07/28/23, 08:03
LocalPath.php:35ReplyAh, scrap this. This property always gets set in `__construct`, and the code there is a bit misleading. -
Stefan Bürk voted on patch set 1 V +1 CR +1 07/28/23, 17:54
-
Christian Kuhn voted on patch set 1 V +2 CR +2 07/28/23, 17:54
-
Christian Kuhn merged patch set 2 07/28/23, 17:54