80196[!!!][TASK] Introduce type declarations in FolderInterface
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
-
Verified V +2 Done
- Christian Kuhn +2
- Oliver Klee +1
- Stefan Bürk +1
- core-ci +1 CI
Issues 1
Files 4
Review log 911
-
Alexander Schnitzler uploaded patch set 1 07/28/23, 06:58
-
core-ci voted on patch set 1 V +1 07/28/23, 07:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44643
-
Alexander Schnitzler wrote 07/28/23, 07:16
Topic set to FAL -
Alexander Schnitzler uploaded patch set 2
V +107/28/23, 07:22 -
core-ci voted on patch set 2 V +1 07/28/23, 07:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44648
-
Oliver Klee commented on patch set 2 V +1 07/28/23, 07:56
Folder.php:318As we're changing the signature anyway, please let's add a type declaration for the parameter (and drop the `@param` annotation) so we only have to touch this line one. -
Oliver Klee commented on patch set 2 07/28/23, 08:01
Folder.php:318Replyone -> once -
Oliver Klee commented on patch set 2 CR +1 07/28/23, 08:06
Folder.php:318ReplyChatted about this - we won't do that in this change. -
Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 17:45
-
Christian Kuhn voted on patch set 2 V +2 CR +2 07/28/23, 17:46
-
Christian Kuhn merged patch set 3 07/28/23, 17:46