Review main Merged

80198[TASK] Prepare runTests.sh to flexible container bin

Christian Kuhn CR +2 V +2 Normal +115 −106 updated 07/28/23, 11:24

Commit message

As a preparation towards podman as container
executor next to docker, runTests.sh is refactored
a bit:

* Image names now always have a host prefix like
  docker.io/ or ghcr.io/, except on CI, which will
  change later, too. podman needs those prefixes and
  does not fall back to docker.io if it's missing:
  "redis:latest" -> "docker.io/redis:latest"
* Image names are now put into variables.
* Rename "docker" to "container" in variables.
* Have a variable for the container binary, set to
  "docker" for now.
* Change the cleanUp() function slightly, it will
  later work with both docker and podman this way.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 68

  1. Christian Kuhn uploaded patch set 1 07/28/23, 07:20

  2. core-ci voted on patch set 1 V +1 07/28/23, 07:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44646

  3. Christian Kuhn updated the commit message in patch set 2 V +1 07/28/23, 07:38

  4. core-ci voted on patch set 2 V +1 07/28/23, 07:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44652

  5. Stefan Bürk voted on patch set 2 V +1 CR +1 07/28/23, 08:15

  6. Jochen Roth voted on patch set 2 V +1 CR +1 07/28/23, 10:36

  7. Christian Kuhn voted on patch set 2 V +2 CR +2 07/28/23, 11:24

  8. Christian Kuhn merged patch set 3 07/28/23, 11:24