Review main Merged

80200[BUGFIX] Make importmaps cacheable

Benjamin Franzke CR +2 V +2 Easy +31 −4 updated 04/16/25, 12:10

Commit message

Render importmaps without a nonce in frontend mode and
supply a hash to the policy registry to allow the page
to be cached, as prepared in #104281.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Andreas Kienast +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Georg Ringer +1
    • Oliver Hader +1
    • core-ci +1 CI

Issues 2

Files 4

Review log 1418

  1. Benjamin Franzke uploaded patch set 1 07/28/23, 07:29

  2. core-ci voted on patch set 1 V -1 07/28/23, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44651

  3. Benjamin Franzke uploaded patch set 2 V -1 07/28/23, 19:52

  4. core-ci voted on patch set 2 V +1 07/28/23, 20:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44700

  5. Benjamin Franzke marked it work in progress 07/28/23, 20:09

  6. Benni Mack updated the commit message in patch set 3 V +1 10/18/24, 14:10

  7. Oliver Hader updated the commit message in patch set 4 10/18/24, 14:13

  8. Garvin Hicking wrote 01/24/25, 19:01

    Topic set to csp
  9. Benjamin Franzke uploaded patch set 5 04/12/25, 10:06

  10. core-ci voted on patch set 5 V +1 04/12/25, 10:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77612

  11. Benjamin Franzke updated the commit message in patch set 6 V +1 04/12/25, 15:13

  12. core-ci voted on patch set 6 V +1 04/12/25, 15:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77626

  13. Oliver Hader commented on patch set 6 CR +1 V +1 04/13/25, 07:56

    PageRenderer.php:1442

    Is there a reason, nonce values should be kept for the backend user interface in general?
  14. Benjamin Franzke commented on patch set 6 04/13/25, 09:12

    PageRenderer.php:1442 Reply

    I don't have any in mind, besides possible overhead for the hash generation.. (which I never measured and don't know whether that's actually relevant, I guess it's not relevant)
  15. Andreas Kienast voted on patch set 6 CR +1 04/15/25, 05:26

  16. Georg Ringer voted on patch set 6 CR +1 V +1 04/16/25, 11:28

  17. Benjamin Franzke commented on patch set 6 CR +2 V +2 04/16/25, 12:09

    PageRenderer.php:1442 Reply

    Done
  18. Benjamin Franzke merged patch set 7 04/16/25, 12:10