Review 11.5 Merged

80203[TASK] Prepare runTests.sh to flexible container bin

Christian Kuhn CR +2 V +2 Normal +117 −107 updated 07/28/23, 11:25

Commit message

As a preparation towards podman as container
executor next to docker, runTests.sh is refactored
a bit:

* Image names now always have a host prefix like
  docker.io/ or ghcr.io/, except on CI, which will
  change later, too. podman needs those prefixes and
  does not fall back to docker.io if it's missing:
  "redis:latest" -> "docker.io/redis:latest"
* Image names are now put into variables.
* Rename "docker" to "container" in variables.
* Have a variable for the container binary, set to
  "docker" for now.
* Change the cleanUp() function slightly, it will
  later work with both docker and podman this way.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1