Review 11.5 Merged

80234[TASK] Use `ignore-platform-req` workaround for `phpspec/prophecy`

Stefan Bürk CR +2 V +2 Easy +6 −2 updated 07/29/23, 14:42

Commit message

The `phpspec/prophecy` defines a hard php version constraint
in the `composer.json` not allowing PHP8.3 for now. This may
tend to take quite some time and therefore the reason why it
has been removed in TYPO3 v12+.

To mitigate this issue way back for early PHP8.2 versions,
a workaround have been used to ignore the php platform req
only for the specific version. This should be reintroduced
for PHP8.3 now.

This change adds the `--ignore-platform-req=php+` workaround
again - but for PHP8.3 only.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 79

  1. Stefan Bürk uploaded patch set 1 07/29/23, 09:15

  2. Stefan Bürk uploaded patch set 2 07/29/23, 09:17

  3. Stefan Bürk uploaded patch set 3 07/29/23, 09:19

  4. Stefan Bürk uploaded patch set 4 07/29/23, 09:21

  5. core-ci voted on patch set 4 V +1 07/29/23, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44723

  6. core-ci commented on patch set 4 07/29/23, 09:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44725

  7. Christian Kuhn voted on patch set 4 V +1 CR +1 07/29/23, 09:59

  8. Stefan Bürk commented on patch set 4 V +2 CR +2 07/29/23, 14:42

    Only test related, let's get it in to have clean nightlies again.
  9. Stefan Bürk merged patch set 5 07/29/23, 14:42