Review main Abandoned Breaking

80237[!!!][TASK] Introduce type declarations in AbstractFile

Alexander Schnitzler CR 0 V 0 Normal +120 −88 updated 08/06/24, 15:08

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 57

  1. Alexander Schnitzler uploaded patch set 1 07/29/23, 09:56

  2. Alexander Schnitzler uploaded patch set 2 07/29/23, 09:56

  3. core-ci voted on patch set 2 V +1 07/29/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44729

  4. core-ci voted on patch set 1 V -1 07/29/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44728

  5. Oliver Klee commented on patch set 2 08/01/23, 13:50

    ProcessedFile.php:486 Unresolved

    Maybe we can have this change (adding the cast) as a separate change that can be backported, too. What do you think?
  6. Christian Kuhn commented on patch set 2 08/06/24, 15:08

    hey. i hope it is ok to abandon here for now since the patch has quite a few merge conflicts by now and various details have been applied already. let's create a fresh issue for type declarations that may not have been applied.
  7. Christian Kuhn abandoned the change 08/06/24, 15:08