80237[!!!][TASK] Introduce type declarations in AbstractFile
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 11
- Build/phpstan/phpstan-baseline.neon+7 −7
- typo3/sysext/core/Classes/Resource/AbstractFile.php+40 −64
- typo3/sysext/core/Classes/Resource/File.php+1 −1
- typo3/sysext/core/Classes/Resource/ProcessedFile.php1+4 −10
- typo3/sysext/core/Classes/Resource/ResourceStorage.php+4 −0
- typo3/sysext/core/Classes/Utility/File/ExtendedFileUtility.php+1 −1
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-101459-IntroduceTypeDeclarationsInAbstractFile.rstnew+58 −0
- typo3/sysext/core/Tests/Unit/LinkHandling/FileLinkHandlerTest.php+1 −1
- typo3/sysext/core/Tests/Unit/LinkHandling/LegacyLinkNotationConverterTest.php+1 −1
- typo3/sysext/core/Tests/Unit/Resource/FileTest.php+2 −2
- typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php+1 −1
Review log 57
-
Alexander Schnitzler uploaded patch set 1 07/29/23, 09:56
-
Alexander Schnitzler uploaded patch set 2 07/29/23, 09:56
-
core-ci voted on patch set 2 V +1 07/29/23, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44729
-
core-ci voted on patch set 1 V -1 07/29/23, 10:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44728
-
Oliver Klee commented on patch set 2 08/01/23, 13:50
-
Christian Kuhn commented on patch set 2 08/06/24, 15:08
hey. i hope it is ok to abandon here for now since the patch has quite a few merge conflicts by now and various details have been applied already. let's create a fresh issue for type declarations that may not have been applied. -
Christian Kuhn abandoned the change 08/06/24, 15:08
ProcessedFile.php:486Unresolved