Review main Merged

80238[TASK] Remove superfluous check in extbase HashService

Torben Hansen CR +2 V +2 Easy +2 −6 updated 08/02/23, 15:33

Commit message

The `generateHmac()` function in extbase `HashService` checks
for the existence of the TYPO3 encryption key and throws an exception
if no encryption key is set. This check is however superfluous, since
`TYPO3\CMS\Core\Core\Bootstrap::checkEncryptionKey()` already does
the same.

The check in extbase `HashService` can therefore safely be removed.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 1