Review main Merged Breaking

80262[!!!][TASK] Add native type declarations to GU file methods

Oliver Klee CR +2 V +2 Normal +40 −42 updated 11/21/23, 18:41

Commit message

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1318

  1. Oliver Klee uploaded patch set 1 07/31/23, 08:16

  2. Oliver Klee commented on patch set 1 CR -1 07/31/23, 08:16

    Still WIP, and we still need the RST.
  3. Oliver Klee uploaded patch set 2 CR -1 07/31/23, 08:22

  4. core-ci voted on patch set 1 V -1 07/31/23, 08:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44780

  5. core-ci voted on patch set 2 V -1 07/31/23, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44781

  6. Oliver Klee uploaded patch set 3 V -1 07/31/23, 11:24

  7. core-ci voted on patch set 3 V +1 07/31/23, 11:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44801

  8. Oliver Klee marked it work in progress 08/25/23, 12:04

  9. Oliver Klee uploaded patch set 4 V +1 11/20/23, 20:33

  10. Oliver Klee marked it ready for review 11/20/23, 20:33

  11. core-ci voted on patch set 4 V +1 11/20/23, 20:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49188

  12. Christian Kuhn commented on patch set 4 11/21/23, 13:54

    GeneralUtility.php:2378

    Let's remove such annotations which are obsolete with proper types now?!
  13. Oliver Klee uploaded patch set 5 V +1 11/21/23, 15:06

  14. Oliver Klee commented on patch set 4 11/21/23, 15:06

    GeneralUtility.php:2378 Reply

    Done
  15. core-ci voted on patch set 5 V +1 11/21/23, 15:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/49247

  16. Stefan Bürk voted on patch set 5 V +1 CR +1 11/21/23, 18:40

  17. Christian Kuhn voted on patch set 5 V +2 CR +2 11/21/23, 18:41

  18. Christian Kuhn merged patch set 6 11/21/23, 18:41